Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug causing graph plot points to all be on same default date #99

Merged
merged 7 commits into from Apr 17, 2014
Merged

Fixed bug causing graph plot points to all be on same default date #99

merged 7 commits into from Apr 17, 2014

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2014

Using a MariaDB we found a bug causing all graphs plot points to be placed on the same date regardless of actual date. Seems to be caused by a float instead of the integer value. Simply a round added in the config file to ensure we get a proper value to plot the graph from.

Bug and fix confirmed on two different invironments and only seems to affect MariaDB setups.

@boxcla
Copy link

boxcla commented Mar 20, 2014

Hi @bjarnek, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@gtowey
Copy link
Contributor

gtowey commented Apr 10, 2014

@bjarnek I like this change and I'd like to merge it; could you take a look at our CLA and sign it so I can merge your changes?

@ghost
Copy link
Author

ghost commented Apr 11, 2014

CLA signed

@boxcla
Copy link

boxcla commented Apr 11, 2014

Verified that @bjarnek has just signed the CLA. Thanks, and we look forward to your contribution.

gtowey added a commit that referenced this pull request Apr 17, 2014
Fixed bug causing graph plot points to all be on same default date
@gtowey gtowey merged commit dec9aea into box:master Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants