Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest git-sync version #16

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Use latest git-sync version #16

merged 2 commits into from
Mar 22, 2018

Conversation

pieterlange
Copy link
Contributor

also removes trailing whitespace.

@ahakanbaba
Copy link
Contributor

@ghodss I do not have any objection in merging this PR.
Is it ok for you ?

@gregory-lyons
Copy link
Contributor

@pieterlange sorry I am just getting around to this now. Thanks for the suggestion. It appears there is now a newer release v0.2.6 available, can you bump the version to that one instead?

@pieterlange
Copy link
Contributor Author

@gregory-lyons This was mostly done in reference to kubernetes/git-sync#58

Take care to include a known_hosts file in your ssh secrets if you're syncing over git+ssh (i think 99% of usecases).
The risk in this case involves cluster takeover if someone can trick your kube-applier+git-sync pod to connect to their repo (through DNS takeover or otherwise).

@gregory-lyons
Copy link
Contributor

@pieterlange can you rebase your commits on top of the current master branch? (sorry, I should have merged yours first before my own #27).

1 similar comment
@gregory-lyons
Copy link
Contributor

@pieterlange can you rebase your commits on top of the current master branch? (sorry, I should have merged yours first before my own #27).

@pieterlange
Copy link
Contributor Author

The commit itself is meaningless, just make sure you understand what's happening with git-sync.

@gregory-lyons gregory-lyons merged commit aff9960 into box:master Mar 22, 2018
brengarajalu pushed a commit to brengarajalu/kube-applier that referenced this pull request Mar 8, 2019
Merge pull request box#16 from skynet/hakan
7254fe5 
Add some comments about the release used and where it is coming from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-lyons gregory-lyons gregory-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieterlange @ahakanbaba @gregory-lyons