Add strict mode
#48
Merged
Add strict mode
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
commented
Dec 19, 2022
nikku
commented
Dec 19, 2022
nikku
commented
Dec 19, 2022
In strict mode `moddle` will fail on unknown property access / instantiation.
Instead of throwing, log a warning when `strict=false` is configured.
This ensures that logging is still opt-in. It won't happen without prior
configuration:
```javascript
const moddle = new Moddle(packages, { strict: false });
```
|
@barmac Reworked this based on our discussion. For the time being At the same time the strict mode (including warnings logged) is added as a non-breaking feature. |
nikku
added
needs review
barmac
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid the transition to #45, add a dedicated mode that fails early if illegal access is attempted on a
ModdleElement.Behavioral changes in a nutshell:
strictmode that fails on unknown property accessxmlns) to be added without warning, if explicitly flaggedThe mode is optional and must be configured explitly as
strict=true:If configured with
strict=falsethen a warning is logged to theconsole, indicating miss-use: