Skip to content

Commit

Permalink
mm: get rid of pagevec_release_nonlru()
Browse files Browse the repository at this point in the history
speculative page references patch (commit:
e286781) removed last
pagevec_release_nonlru() caller.

So this function can be removed now.

This patch doesn't have any functional change.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
kosaki authored and torvalds committed Jan 6, 2009
1 parent 5594c8c commit 1b0bd11
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 29 deletions.
7 changes: 0 additions & 7 deletions include/linux/pagevec.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ struct pagevec {
};

void __pagevec_release(struct pagevec *pvec);
void __pagevec_release_nonlru(struct pagevec *pvec);
void __pagevec_free(struct pagevec *pvec);
void ____pagevec_lru_add(struct pagevec *pvec, enum lru_list lru);
void pagevec_strip(struct pagevec *pvec);
Expand Down Expand Up @@ -69,12 +68,6 @@ static inline void pagevec_release(struct pagevec *pvec)
__pagevec_release(pvec);
}

static inline void pagevec_release_nonlru(struct pagevec *pvec)
{
if (pagevec_count(pvec))
__pagevec_release_nonlru(pvec);
}

static inline void pagevec_free(struct pagevec *pvec)
{
if (pagevec_count(pvec))
Expand Down
22 changes: 0 additions & 22 deletions mm/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,28 +397,6 @@ void __pagevec_release(struct pagevec *pvec)

EXPORT_SYMBOL(__pagevec_release);

/*
* pagevec_release() for pages which are known to not be on the LRU
*
* This function reinitialises the caller's pagevec.
*/
void __pagevec_release_nonlru(struct pagevec *pvec)
{
int i;
struct pagevec pages_to_free;

pagevec_init(&pages_to_free, pvec->cold);
for (i = 0; i < pagevec_count(pvec); i++) {
struct page *page = pvec->pages[i];

VM_BUG_ON(PageLRU(page));
if (put_page_testzero(page))
pagevec_add(&pages_to_free, page);
}
pagevec_free(&pages_to_free);
pagevec_reinit(pvec);
}

/*
* Add the passed pages to the LRU, then drop the caller's refcount
* on them. Reinitialises the caller's pagevec.
Expand Down

0 comments on commit 1b0bd11

Please sign in to comment.