Skip to content

Commit

Permalink
latencytop: fix per task accumulator
Browse files Browse the repository at this point in the history
Per task latencytop accumulator prematurely terminates due to erroneous
placement of latency_record_count.  It should be incremented whenever a
new record is allocated instead of increment on every latencytop event.

Also fix search iterator to only search known record events instead of
blindly searching all pre-allocated space.

Signed-off-by: Ken Chen <kenchen@google.com>
Reviewed-by: Arjan van de Ven <arjan@infradead.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ken Chen authored and torvalds committed Nov 12, 2010
1 parent 8d056cb commit 3871525
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions kernel/latencytop.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,7 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)

account_global_scheduler_latency(tsk, &lat);

/*
* short term hack; if we're > 32 we stop; future we recycle:
*/
tsk->latency_record_count++;
if (tsk->latency_record_count >= LT_SAVECOUNT)
goto out_unlock;

for (i = 0; i < LT_SAVECOUNT; i++) {
for (i = 0; i < tsk->latency_record_count; i++) {
struct latency_record *mylat;
int same = 1;

Expand All @@ -227,8 +220,14 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)
}
}

/*
* short term hack; if we're > 32 we stop; future we recycle:
*/
if (tsk->latency_record_count >= LT_SAVECOUNT)
goto out_unlock;

/* Allocated a new one: */
i = tsk->latency_record_count;
i = tsk->latency_record_count++;
memcpy(&tsk->latency_record[i], &lat, sizeof(struct latency_record));

out_unlock:
Expand Down

0 comments on commit 3871525

Please sign in to comment.