Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate into updated Vite structure #578

Open
10 of 14 tasks
baruchiro opened this issue Aug 19, 2024 · 11 comments
Open
10 of 14 tasks

Migrate into updated Vite structure #578

baruchiro opened this issue Aug 19, 2024 · 11 comments

Comments

@baruchiro
Copy link
Collaborator

baruchiro commented Aug 19, 2024

We have many deprecated dependencies and can't upgrade the israeli-bank-scrapers anymore because it upgraded its NodeJS version.

I migrated our code into a new updated template, with the latest technologies and a better project structure to support us in the future.

PR: #579

Here is what is missing to finish the migration:

Critical

  • CI: Need to migrate our CI pipeline (the validations on Pull Requests) into the new project
    • Lint (if it pass)
    • TypeScript check
    • Build
  • CD: Need to migrate our publish procedure, and learn how the new project needs to be deployed (is it using electron-builder as we do, or something else?)
    • Semantic-Release
    • Create Release
    • Upload Artifacts
  • Link to Discord (critical because I account this to be in contact with users and leave other things in "Not Critical")
  • Check YNAB
  • Copy nuxt files and deployment

Can be fixed after migration

  • TypeScript issues
  • Check for updates
  • Readme file

Close #428

@brafdlog
Copy link
Owner

Fixed multiple Ynab issues. Ynab works now

@brafdlog
Copy link
Owner

Fixed discord link

@baruchiro
Copy link
Collaborator Author

baruchiro commented Sep 2, 2024

image

Update: problem solved

@baruchiro
Copy link
Collaborator Author

baruchiro commented Sep 5, 2024

Now need to inject the Google client ID and client secret into the pipeline.

BTW, I failed to download the draft artifacts, don't know why, but in case you need another way, use this:

gh release download v2.0.0-test.3 --pattern "caspion-2.0.0-test.3-arm64.dmg" --dir release

Done

@shaiu
Copy link
Contributor

shaiu commented Sep 15, 2024

@baruchiro lint is working now so you can cross it out :)

baruchiro added a commit that referenced this issue Sep 18, 2024
Part of #578

---------

Co-authored-by: Jonathan <brafdlog@gmail.com>
Co-authored-by: Shai Ungar <shaiungar@gmail.com>
@brafdlog
Copy link
Owner

@baruchiro what solved this issue? I still see this issue when installing from the latest released version

image

Update: problem solved

@shaiu
Copy link
Contributor

shaiu commented Sep 21, 2024

@brafdlog I also see it. I'm debugging it now

@shaiu
Copy link
Contributor

shaiu commented Sep 21, 2024

@brafdlog I found the issue.
Sending a PR

@shaiu
Copy link
Contributor

shaiu commented Sep 21, 2024

@brafdlog @baruchiro #594

@brafdlog
Copy link
Owner

Nice, thanks @shaiu
Merged the PR

@shaiu
Copy link
Contributor

shaiu commented Sep 21, 2024

@brafdlog @baruchiro fixed tests + lint + typecheck: #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants