The most basic possible test for read_phy_files(). #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression in #10 revealed that this wasn't being tested. This commit just loads one known-good dataset to verify that the function can complete and return a SpikeData, like existing tests of load_spike_data(). Also makes these tests online-only so they can be easily disabled for faster testing of other methods.
ashsrobbins
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression in #10 revealed that this wasn't being tested. This
commit just loads one known-good dataset to verify that the function can
complete and return a SpikeData, like existing tests of
load_spike_data().
Also makes these tests online-only so they can be easily disabled for
faster testing of other methods.