Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter function for raw data #41

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

surygeng
Copy link
Contributor

Add a butterworth filter function for getting LFP from raw data.

Copy link
Contributor

@pupster90 pupster90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this has the filter function in it

@pupster90
Copy link
Contributor

does this merge?

@pupster90 pupster90 merged commit 7971165 into master Oct 17, 2023
1 check failed
@atspaeth
Copy link
Member

atspaeth commented Oct 18, 2023

What's the difference between this and the one that's just called filter()? (Added by @ashsrobbins a while back.) Can we consolidate the two?

@surygeng
Copy link
Contributor Author

This new function is simpler. It can be lowpass, highpass, or bandpass, depending on the cutoff value. It returns the same shape of data as the input. Also, the scipy sosfiltfilt function is used since it performs well over other filters. Frequency response was checked.

@atspaeth
Copy link
Member

Great, so the only pro of the old one is that it's chunked/incremental. @ashsrobbins do we actually use that? Is it faster in practice on sufficiently large data or something?

Otherwise I can put together a PR that deprecates the old one and uses the new one in SpikeData.from_thresholded()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants