Merge development branch into the master branch
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize repo packaging based on sci py cookie
fix: bring back missing .so file and remove from gitignore
Updated ci and cd yaml to trigger on development branch
Pinned neuraltoolkit dependency to version 0.3.1 only. @lsetiawan: From some investigation, the actual functions that are being used in the braingeneers package from neuraltoolkit hasn't changed in over a year. And the latest stable v0.3.1 was released in March 2023. So it is safe to use this specific version and minimize breakage.
Sync current code within master into the development branch that contains packaging changes.
Update installation instructions
Co-authored-by: Lon Blauvelt <lblauvel@ucsc.edu>
Remove commented `sortedcontainers` dependency Co-authored-by: Lon Blauvelt <lblauvel@ucsc.edu>
Remove `braingeneers-smart-open` statement Resolves comment #42 (comment)
Updated link for AWS Data Wrangler
Add link to the `CONTRIBUTING.md` file Resolves comment #42 (comment)
lsetiawan
suggested changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks for your detailed review @DailyDreaming! Those are very helpful feedback. 😄
@uwcdc please update as I commented above. Thanks!
Remove `PyLint` Resolves comment #42 (comment)
Resolves comment #42 (comment)
Remove the `_compat` module Part 1 of resolving comment #42 (comment)
Remove the `_compat` module tests Part 2 of resolving comment #42 (comment)
Remove the `_compat` module import Part 3 of resolving comment #42 (comment)
Updated the `ci.yml` to allow for Python 3.12 (experimental) support Added `continue-on-error` functionality in case the experimental support fails since it is new Resolves comment #42 (comment) @lsetiawan could you review the changes that I made here?
Commenting out `continue-on-error`
Remove commented line
Updated `python-version` to num
DailyDreaming
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
@lsetiawan @uwcdc This looks great. Thanks for addressing all of the comments.
I'm suggesting the MIT license after consulting with our managers on this side. Once that's changed, I think that this is good to merge. Thanks again!
Updated the LICENSE to MIT
Update to include the MIT license
lsetiawan
reviewed
Oct 26, 2023
Removed commented `pre-commit` section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains project restructuring and installation changes from @lsetiawan and @uwcdc. The project now follows the Scientific Python standards laid out by Scientific Python. In addition, the following dependencies were updated:
neuraltoolkitsmart-openDue to the fact that the dependence on
neuraltoolkithas not been used in over a year, thepip install neuraltoolkit(v0.3.1) was substituted, and the project built without any error.In addition, the dependence on
smart-opendiverged from themasterrepo, so the original fork has been maintained internally by the Braingeneers. Consequently, the fork was migrated to here.