Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Brains and Beards website mobile responsive #9

Merged
merged 10 commits into from
Oct 21, 2017
Merged

Make Brains and Beards website mobile responsive #9

merged 10 commits into from
Oct 21, 2017

Conversation

lawmbass
Copy link
Contributor

Using Bootstrap 4

screen shot 2017-10-13 at 10 50 39 pm
screen shot 2017-10-13 at 10 51 00 pm
screen shot 2017-10-13 at 10 51 11 pm
screen shot 2017-10-13 at 10 51 28 pm
screen shot 2017-10-13 at 10 51 42 pm

@lawmbass lawmbass changed the title Make Brains and Beards website mobile responsive Make Brains and Beards website mobile responsive Fixes #1 Oct 14, 2017
@lawmbass lawmbass changed the title Make Brains and Beards website mobile responsive Fixes #1 Make Brains and Beards website mobile responsive Oct 14, 2017
@lawmbass
Copy link
Contributor Author

Fixes #1

@lawmbass
Copy link
Contributor Author

Hey @sharnik, can you give me some feedback on this PR

@sharnik
Copy link
Member

sharnik commented Oct 19, 2017

Sorry for late response, I just had a chance to look at it.
First of all, thank you so much for your work, we really appreciate it! It looks great on small screens now.

A little bit of nitpicking:

  • I saw that you changed the indentation from 2 spaces to a tab, we'll need to re-format that
  • We need to add a max-width, because it looks bad on really wide screens:
    screen shot 2017-10-19 at 08 33 28

If you have a minute, you can update the PR, or I'll add those small changes myself when merging over the weekend.

@lawmbass
Copy link
Contributor Author

Good catch, sure I'll make those changes to the PR this evening 👌

@lawmbass
Copy link
Contributor Author

lawmbass commented Oct 19, 2017 •
edited
Loading

  • Change indentation from tabs to 2 spaces
  • Add max-width to prevent content overflow on large screens

@lawmbass
Copy link
Contributor Author

Hey @sharnik, I've gone ahead and made the necessary changes to fix the issues you came across earlier. Let me know what you think. 👍

@sharnik sharnik merged commit e950bb5 into brains-and-beards:master Oct 21, 2017
@sharnik
Copy link
Member

sharnik commented Oct 21, 2017

Thanks so much, merged!

@lawmbass
Copy link
Contributor Author

lawmbass commented Oct 21, 2017 •
edited
Loading

No problem, I had fun working on it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawmbass @sharnik