Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Filter not working #228

Closed
ballo opened this issue Dec 6, 2019 · 1 comment
Closed

Filter not working #228

ballo opened this issue Dec 6, 2019 · 1 comment

Comments

@ballo
Copy link

ballo commented Dec 6, 2019

This filter doesn't work in Brave (OSX version, if that matters):
ebay.com#@#li.s-item:-abp-has(span:-abp-contains(SPONSORED))
Works fine in µBlock Origin for Chromium

@pes10k
Copy link
Collaborator

pes10k commented Dec 6, 2019

Howdy @ballo

We don't currently ship / support cosmetic filters, though we will soon (no promises but we hope it'll go into nightly shortly). You can follow the issue here brave/brave-browser#5381

Until Brave enables cosmetic filtering, rules like the above definitely won't work. But even when cosmetic filtering goes live, we don't currently support all of the ABP additions to filter rules. We have an issue to support them here brave/adblock-rust#59, though we expect that adding support for the above, procedurally enforced style of rules will be low priority for a while.

Closing this as a dupe of brave/adblock-rust#59. Thanks for the issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants