Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Solana RPC Values on Authorize #2515

Open
wants to merge 4 commits into
base: nitro-payments-dev
Choose a base branch
from
Open

Cache Solana RPC Values on Authorize #2515

wants to merge 4 commits into from

Conversation

Sneagan
Copy link
Contributor

@Sneagan Sneagan commented May 10, 2024

Summary

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@Sneagan Sneagan requested a review from evq May 10, 2024 02:19
@Sneagan Sneagan requested review from a team as code owners May 10, 2024 02:19
pavelbrm
pavelbrm reviewed May 10, 2024
View reviewed changes
services/payments/statemachine_solana.go
Comment on lines +64 to +68
var (
err error
blockHash string
slotTarget uint64
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move these closer to where it's needed.

services/payments/statemachine_solana.go Outdated Show resolved Hide resolved
services/payments/statemachine_solana.go Outdated Show resolved Hide resolved
services/payments/statemachine_solana.go Outdated Show resolved Hide resolved
Sneagan and others added 3 commits May 10, 2024 16:23
@Sneagan @pavelbrm
Update services/payments/statemachine_solana.go
3b3aa0c 
Co-authored-by: Pavel Brm <5097196+pavelbrm@users.noreply.github.com>
@Sneagan @pavelbrm
Update services/payments/statemachine_solana.go
d14c9fc 
Co-authored-by: Pavel Brm <5097196+pavelbrm@users.noreply.github.com>
@Sneagan @pavelbrm
Update services/payments/statemachine_solana.go
34ce0cf 
Co-authored-by: Pavel Brm <5097196+pavelbrm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm pavelbrm left review comments

@evq evq Awaiting requested review from evq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sneagan @pavelbrm