Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Get Wallet Endpoint Result #895

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Correct Get Wallet Endpoint Result #895

merged 1 commit into from
Jul 30, 2021

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Jul 29, 2021

Summary

Corrects the get wallet endpoint to send back the card identifier (used to be provider_id)

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@husobee husobee self-assigned this Jul 29, 2021
@LaurenWags LaurenWags mentioned this pull request Jul 30, 2021
Closed
@husobee husobee merged commit 7dee35f into master Jul 30, 2021
@husobee husobee deleted the get-wallet-dap branch July 30, 2021 12:25
@husobee husobee mentioned this pull request Jul 30, 2021
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yachtcaptain23 yachtcaptain23 yachtcaptain23 approved these changes

Assignees

@husobee husobee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@husobee @yachtcaptain23