Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address clicks.trx-hub.com debounce #2108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Address clicks.trx-hub.com debounce #2108

wants to merge 1 commit into from

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Oct 17, 2024

From https://www.mensjournal.com/gear/best-casio-watches

https://clicks.trx-hub.com/xid/arena_0b263_mensjournal?event_type=click&q=https%3A%2F%2Fgo.skimresources.com%2F%3Fid%3D106246X1712071%26xs%3D1%26xcust%3DMj-bestcasiowatches-abible-1024%26url%3Dhttps%253A%252F%252Fwww.casio.com%252Fus%252Fwatches%252Fgshock%252Fproduct.MRG-BF1000B-1A%252F&p=https%3A%2F%2Fwww.mensjournal.com%2Fgear%2Fbest-casio-watches&ContentId=ci02e8495b300024a9&author=Christopher+Friedmann&page_type=Article+Page&section=Gear&site_id=cs02b334a3f0002583&mc=www.mensjournal.com&ref=https%3A%2F%2Fwww.mensjournal.com%2F&exp=tempest-9188-aff%3Aa%7Ctempest-9188-brnd%3Aa&mcor=8314662660334384

Could change the "://clicks.trx-hub.com/xid/&ref=" and use "ref" param

@ryanbr ryanbr added the Debounce Debouncing list related label Oct 17, 2024
@ryanbr ryanbr requested a review from fmarier October 17, 2024 09:36
@ryanbr ryanbr self-assigned this Oct 17, 2024
@ryanbr ryanbr requested a review from a team as a code owner October 17, 2024 09:36
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome, the sample URL goes to:

https://go.skimresources.com/?id=106246X1712071&xs=1&xcust=Mj-bestcasiowatches-abible-1024|xid:fr1729184222427ufq&url=https%3A%2F%2Fwww.casio.com%2Fus%2Fwatches%2Fgshock%2Fproduct.MRG-BF1000B-1A%2F

which then goes to:

https://www.casio.com/us/watches/gshock/product.MRG-BF1000B-1A/

So if we use the q parameter:

https%3A%2F%2Fgo.skimresources.com%2F%3Fid%3D106246X1712071%26xs%3D1%26xcust%3DMj-bestcasiowatches-abible-1024%26url%3Dhttps%253A%252F%252Fwww.casio.com%252Fus%252Fwatches%252Fgshock%252Fproduct.MRG-BF1000B-1A%252F

which decodes to:

https://go.skimresources.com/?id=106246X1712071&xs=1&xcust=Mj-bestcasiowatches-abible-1024&url=https%3A%2F%2Fwww.casio.com%2Fus%2Fwatches%2Fgshock%2Fproduct.MRG-BF1000B-1A%2F

it will get debounced by an existing rule into the url parameter:

https%3A%2F%2Fwww.casio.com%2Fus%2Fwatches%2Fgshock%2Fproduct.MRG-BF1000B-1A%2F

which decodes to:

https://www.casio.com/us/watches/gshock/product.MRG-BF1000B-1A/

That's the same as following the redirects in Chrome.

@fmarier
Copy link
Member

fmarier commented Oct 17, 2024

Could change the "://clicks.trx-hub.com/xid/&ref=" and use "ref" param

The ref parameter above is not the destination. It's the referrer and so we can't use that one since it would take users to the wrong page (i.e. back to where they started).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debounce Debouncing list related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants