Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Fix deps in //brave/components/brave_shields/browser/* #10643

Closed
jumde opened this issue Jul 8, 2020 · 0 comments · Fixed by brave/brave-core#8738
Closed

[Desktop] Fix deps in //brave/components/brave_shields/browser/* #10643

jumde opened this issue Jul 8, 2020 · 0 comments · Fixed by brave/brave-core#8738
Assignees
@bridiver
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.26.x - Release

Comments

@jumde
Copy link
Contributor

jumde commented Jul 8, 2020 

$ gn check . //brave/components/brave_shields/browser/*
ERROR at //brave/components/brave_shields/browser/ad_block_service.cc:20:11: Include not allowed.
#include "brave/browser/brave_browser_process_impl.h"
          ^-----------------------------------------
It is not in any dependency of
  //brave/components/brave_shields/browser:browser
The include file is in the target(s):
  //brave/browser:browser_process
which should somehow be reachable.
___________________
ERROR at //brave/components/brave_shields/browser/ad_block_service.cc:21:11: Can't include this header from here.
#include "brave/common/pref_names.h"
          ^------------------------
The target:
  //brave/components/brave_shields/browser:browser
is including a file from the target:
  //brave/common:pref_names
@bridiver bridiver mentioned this issue May 7, 2021
Merged
24 tasks
@bridiver bridiver self-assigned this May 7, 2021
bridiver added a commit to brave/brave-core that referenced this issue May 7, 2021
@bridiver
fix brave/components/brave_shields deps
c4b960c 
fixes brave/brave-browser#10643
bridiver added a commit to brave/brave-core that referenced this issue May 11, 2021
@bridiver
fix brave/components/brave_shields deps
3fd7c07 
fixes brave/brave-browser#10643
@bridiver bridiver added this to the 1.26.x - Nightly milestone May 14, 2021
mkarolin pushed a commit to brave/brave-core that referenced this issue Aug 18, 2021
@mariospr @mkarolin
fixup! fix brave/components/brave_shields deps fixes brave/brave-brow…
6afce0b 
…ser#10643

This browser tests got moved into //brave/browser/brave_shields but
got removed from its original location, so let's do it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.26.x - Release
Development

Successfully merging a pull request may close this issue.

fix brave/components/brave_shields deps brave/brave-core
2 participants
@bridiver @jumde