Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprinting 2.0: Plugins (mimetype) #10718

Closed
pes10k opened this issue Jul 13, 2020 · 1 comment · Fixed by brave/brave-core#6067
Closed

Fingerprinting 2.0: Plugins (mimetype) #10718

pes10k opened this issue Jul 13, 2020 · 1 comment · Fixed by brave/brave-core#6067
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude webcompat/shields Shields is breaking a website.

Comments

@pes10k
Copy link
Contributor

pes10k commented Jul 13, 2020

Continuing from #9435

The new fake plugins we're adding are causing naive JS code to crash because it assumes that every plugin has at least 1 associated MIME type, so code like navigator.plugins[0][0].type crashes. So the fake plugins we create and inject into navigator.plugins should also include at least 1 associated MIME type.

STR as per @pilgrim-brave:

As per #10716, run through the following STR/Cases:

  1. Go to espn.com
  2. Scroll to any of the videos.
  3. Hit play button on any of the videos (the short ones not the ones that to go to premium service) and notice the video doesn't play.
@pes10k pes10k added feature/shields The overall Shields feature in Brave. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields webcompat/shields Shields is breaking a website. privacy-pod Feature work for the Privacy & Web Compatibility pod OS/Desktop labels Jul 13, 2020
@pes10k pes10k added this to the 1.13.x - Nightly milestone Jul 16, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 22, 2020
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Jul 27, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 31, 2020

Verification passed on


Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)



Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude webcompat/shields Shields is breaking a website.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants