Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement associated MIME info for fake plugins #6067

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jul 13, 2020

Resolves brave/brave-browser#10718

Submitter Checklist:

Test Plan:

As per brave/brave-browser#10716, run through the following STR/Cases:

  1. Go to espn.com
  2. Scroll to any of the videos.
  3. Hit play button on any of the videos (the short ones not the ones that to go to premium service) and notice the video doesn't play.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_navigator_plugins_mime branch from d7c4efe to cefe3cd Compare July 14, 2020 17:12
@pilgrim-brave
Copy link
Contributor Author

all test failures are known and unrelated

@pilgrim-brave pilgrim-brave merged commit d3f8fd2 into master Jul 14, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_navigator_plugins_mime branch July 14, 2020 19:41
brave-builds pushed a commit that referenced this pull request Jul 22, 2020
@pilgrim-brave pilgrim-brave added this to the 1.13.x - Nightly milestone Jul 23, 2020
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.13.45 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.15.6 (Build 19G73)

@rebron
Copy link
Collaborator

rebron commented Jul 27, 2020

Reproduced original issue on macOS 1.12.98 and Windows version below.

Brave 1.12.91 Chromium: 84.0.4147.89 (Official Build) beta (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Windows 10 OS Version 2004 (Build 19041.388)

Verified PASSED on macOS 1.13.45 and Windows below:

Brave 1.13.42 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Windows 10 OS Version 2004 (Build 19041.388)

Using STR via brave/brave-browser#10716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: Plugins (mimetype)
4 participants