Implement Ads tab on brave://rewards-internals with diagnostic information

[tmancey]

• Status: Enabled / Disabled
• Users locale en_US
• Catalog id 9b545656-f314-48d7-9c52-978f68491b35
• Catalog last updated timestamp 06/27/21 05:43:12 PM
• Last un-idle timestamp 06/27/21 05:43:12 PM

[moritzhaller]

I've added the following:

- language code and page classifier model ID
- country code and purchase intent model ID

[tmancey]

MVP delivered with

Users locale [LocaleHelper]
Status: Enabled/disabled [prefs::kEnabled]
Catalog id [prefs::kCatalogId]
Catalog last updated timestamp [prefs::kCatalogLastUpdated]
Last un-idle timestamp [AdsImpl::OnUnIdle]

We will write up a document for sign-off from the support and privacy teams for additional data points

[stephendonner]

Verified PASSED using

Brave	1.30.24 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision	6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS	macOS Version 12.0 (Build 21A5294g)

Steps:

1. new profile
2. launched Brave
3. loaded brave://rewards-internals and clicked on the Ad diagnostics tab
4. clicked Refresh; confirmed nothing displayed
5. opened brave://rewards and enabled Ads
6. clicked Refresh; confirmed I got diagnostic info
7. disabled Ads and refreshed brave://rewards-internals; confirmed I saw Ads not initialized, please refresh the page.

example	example	example

---

Verified PASSED using

Brave	1.30.66 Chromium: 93.0.4577.63 (Official Build) dev (64-bit)
Revision	ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS	Linux

Steps:

1. new profile
2. launched Brave
3. loaded brave://rewards-internals and clicked on the Ad diagnostics tab
4. clicked Refresh; confirmed nothing displayed
5. opened brave://rewards and enabled Ads
6. clicked Refresh; confirmed I got diagnostic info
7. disabled Ads and refreshed brave://rewards-internals; confirmed I saw Ads not initialized, please refresh the page.

example	example	example

---

Verification passed on

Brave | 1.30.65 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Verified the test plan from brave/brave-core#9553

Clean profile

Enable rewards/ads via BR panel:

rewards/ads off	rewards/ads on

Enable rewards/ads via brave rewards side bar option:

rewards/ads off	rewards/ads on

Enable rewards/ads via brave rewards settings page:

rewards/ads off	rewards/ads on

Enable rewards, disable Ads

rewards/ads off	rewards/ads on

Upgrade profile:

Install 1.29.x and enable rewards and upgrade profile to 1.30.x check Ad diagnostic stats

1.29.x	1.30.x

Install 1.29.x and enable rewards, disable ads and upgrade profile to 1.30.x check Ad diagnostic stats

1.29.x	1.30.x

[tmancey]

@stephendonner would you mind raising an issue for ads as if disabled we should show Ads enabled: false. Thanks

[stephendonner]

@stephendonner would you mind raising an issue for ads as if disabled we should show Ads enabled: false. Thanks

Filed #17535.

[stephendonner]

Quick verification, and it'd be good to have this be tested on all platforms, being ads-related 👍

[srirambv]

Verification passed on Oppo Reno 5 with Android 11 running 1.30.76 x64 build

• Verified when ads is disabled, diagnostics page shows ads not initialized
• Verified when ads is enabled, diagnostics page shows details about Location/Catalog ID/Last updated datetime stamp

---

Verification passed on Samsung Tab A with Android 10 running 1.30.76 x64 build

• Verified when ads is disabled, diagnostics page shows ads not initialized
• Verified when ads is enabled, diagnostics page shows details about Location/Catalog ID/Last updated datetime stamp