Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Updater Bugs: (1) Pop-under window announcing updates (2) Failed updating due to failure to authorize #12179

Open
DerekCurrie opened this issue Oct 16, 2020 · 0 comments
Labels
feature/updater OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon".

Comments

@DerekCurrie
Copy link

Description

Bug (1) When an update is available for the desktop version on macOS, the announcement window pops UNDER the main browser window where no one will see it. Users have to go look for an update announcement window to see it. Make this a pop-OVER update announcement window to solve the bug. This bug ALWAYS occurs, no exception.

Bug (2) During the installation process, after a successful approval by an Admin account's ID and password, the installation FAILS with this error:

"Failed to change owner & group on Brave Browser.app to match Brave Browser.app with authorization."

This error is unique to Brave and never occurs with any other app. I have verified my permissions within my macOS installation are correct. There is no actual owner & group conflict. This is a false error thrown by the Brave update installer due to its own internal bug, not due to any authorization problem or permission problem in my installation of macOS. This bug ALWAYS occurs, no exception.

The only workaround is to manually download the latest version of the Brave.dmg, open it and drop it into Applications on top of the older version. This workaround works every time. If the update installer worked properly, it would not be necessary.

Steps to Reproduce Bug (1)

  1. Open Brave browser.
  2. Go to brave://settings/help
  3. The interface says "Checking for updates" alongside a revolving activity icon. There is no visual indication of that checking having ended, which is a bad interface problem on its own. The user is left assuming the continual 'Checking' means there is no update.
  4. Unseen and unseeable behind the browser window is any Software Update window. No user is going to look for a pop-under update window. This must be made a pop-over window in ALL cases.
  5. A persistent user might reload the page for brave://settings/help . If they do, NOW the Software Update properly pops over the browser window. This of course is entirely unintuitive.

Steps to Reproduce Bug (2)

  1. Initiate the Brave update installer from its [hidden] window and approve the installation with accurate Admin account ID and password, verified to be accurate.
  2. The update installation proceeds but FAILs with the resulting "Failed to change owner & group..." error message. The only option is to hit "OK" and manually download and install the update.

Actual result:

Bug (1)

Bug (1) Screenshot A - No visible Software Update window due to Pop-Under

Bug (1) Screenshot B - No visible Software Update window due to Pop-Under

Bug (2)

Bug (2) Screenshot - Update installer failure error window

Expected result:

Bug (1): The Software Update announcement window must become a pop-over window, not pop-under.

Bug (2) The update installer must properly install Brave updates without fail.

Reproduces how often:

Bugs (1) and (2): These bugs ALWAYS occur, no exception.

Brave version (brave://version info)

Brave 1.15.72 Chromium: 86.0.4240.75 (Official Build) (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

Bugs (1) and (2):

  • Can you reproduce this issue with the current release?
    Yes, and many versions previous to it.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No, not applicable.

  • Does the issue resolve itself when disabling Brave Rewards?
    No, not applicable.

  • Is the issue reproducible on the latest version of Chrome?
    No, not applicable.

Miscellaneous Information:

My computer is a late 2013 MacBook Pro 11,3 running macOS 10.14.6. I am installing from a client account using the Admin account ID and password to approve the update installation. This is proper procedure.

@rebron rebron added OS/macOS feature/updater priority/P4 Planned work. We expect to get to it "soon". labels Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/updater OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P4 Backlog
Development

No branches or pull requests

2 participants