Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error/warning page communication and iconography #1149

Open
rossmoody opened this issue Sep 16, 2018 · 10 comments
Open

Update error/warning page communication and iconography #1149

rossmoody opened this issue Sep 16, 2018 · 10 comments
Assignees
Labels
branding feature/safebrowsing OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include security

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Sep 16, 2018

Description

Generally speaking we need to update the error page communication to omit mentions of the Chrome brand, chrome support links and chrome iconography across the board. This encompasses 60+ instances of communication between all the error page variations though the iconography specifically seems to fall specifically within these 6 icon groups:

  1. Network Error pages - Sad document icon
  2. SSL Errors - Red Triangle Alert Icon
  3. Clock is ahead/behind - Clock icon
  4. Loud Malware/Phishing pages - White Triangle Alert Icons (red background)
  5. Captive Portal - Wifi symbol
  6. No internet - Dinosaur

Additionally, the typographic and button styling should be updated to Brave brand parity. i.e. Poppins, Muli and rounded button aesthetic. This could also be a unique opportunity to introduce some brand personality and talk to users with a little more care and relatable verbiage since it directly relates to their security which is pretty central to Brave values.

Steps to Reproduce

  1. Type "chrome://interstitials/" into the brave URL bar to view ssl, clock, loud security alert and captive portal error states.
  2. Type "chrome://network-errors/" into the brave URL bar to view network error states.
  3. Type "chrome://dino/" into the Brave URL bar to view the "no internet" state.
  4. Cross check with https://testsafebrowsing.appspot.com/ to cover more use cases

Actual result:

Chrome Examples

Expected result:

This is a proposed initial stylistic update to the iconography for these states.

image

Page might charge you money:
image

Connection not private:

image

Malware warning:

image

Phishing warning:

image

Unwanted software warning:

image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A49

Additional Information

To get a better understanding of the variations encompassing error page communication in this issue visit the info strings logic docs on chromium for interstitial errors and general error pages.

@rebron
Copy link
Collaborator

rebron commented Oct 10, 2018

cc: @Brave-Matt on the info links. If this is ready, could we get this into 0.55.x? No reason to wait.

@rebron rebron modified the milestones: 1.0, 0.56.x - Beta Oct 16, 2018
@petemill
Copy link
Member

Great work @rossmoody! I'll work on the styles.

@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018
@tildelowengrimm tildelowengrimm removed their assignment Nov 30, 2018
@karenkliu
Copy link

This is a dupe of #7464

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Dec 4, 2020
@karenkliu
Copy link

Reopening this for Desktop+Android. iOS has a different Safe Browsing setup so we still need these error pages done for Desktop+Android.

@karenkliu karenkliu reopened this Aug 25, 2021
@karenkliu karenkliu added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 25, 2021
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include and removed closed/duplicate Issue has already been reported priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding feature/safebrowsing OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include security
Projects
Status: P4 backlog
Development

No branches or pull requests

9 participants