-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error/warning page communication and iconography #1149
Labels
branding
feature/safebrowsing
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
release-notes/include
security
Comments
rossmoody
added
security
design
A design change, especially one which needs input from the design team
labels
Sep 16, 2018
This was referenced Sep 16, 2018
cc: @Brave-Matt on the info links. If this is ready, could we get this into 0.55.x? No reason to wait. |
Great work @rossmoody! I'll work on the styles. |
bbondy
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Oct 30, 2018
This was referenced Oct 12, 2020
This was referenced Oct 14, 2020
This was referenced Oct 14, 2020
This is a dupe of #7464 |
Reopening this for Desktop+Android. iOS has a different Safe Browsing setup so we still need these error pages done for Desktop+Android. |
karenkliu
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Aug 25, 2021
rebron
added
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
release-notes/include
and removed
closed/duplicate
Issue has already been reported
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branding
feature/safebrowsing
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
release-notes/include
security
Description
Generally speaking we need to update the error page communication to omit mentions of the Chrome brand, chrome support links and chrome iconography across the board. This encompasses 60+ instances of communication between all the error page variations though the iconography specifically seems to fall specifically within these 6 icon groups:
Additionally, the typographic and button styling should be updated to Brave brand parity. i.e. Poppins, Muli and rounded button aesthetic. This could also be a unique opportunity to introduce some brand personality and talk to users with a little more care and relatable verbiage since it directly relates to their security which is pretty central to Brave values.
Steps to Reproduce
Actual result:
Expected result:
This is a proposed initial stylistic update to the iconography for these states.
Page might charge you money:
Connection not private:
Malware warning:
Phishing warning:
Unwanted software warning:
Assets
Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A49
Additional Information
To get a better understanding of the variations encompassing error page communication in this issue visit the info strings logic docs on chromium for interstitial errors and general error pages.
The text was updated successfully, but these errors were encountered: