Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on Ads and Auto contribute Tos and policy message isn't translated #12427

Closed
GeetaSarvadnya opened this issue Oct 30, 2020 · 2 comments
Closed

Comments

@GeetaSarvadnya
Copy link

Description

Turn on Ads and Auto contribute Tos and policy message isn't translated

Steps to Reproduce

  1. Set OS locale to France/Germany
  2. Open brave://rewards page

Actual result:

Turn on Ads and Auto contribute Tos and policy message isn't translated
image

Expected result:

Turn on Ads and Auto contribute Tos and policy message should be translated

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.18.22 Chromium: 87.0.4280.27 (Official Build) nightly (64-bit)
Revision d8c1fe98de8d9c6bd46ebe8b0cc9d2b6bdccca1e-refs/branch-heads/4280@{#556}
OS Windows 10 OS Version 1903 (Build 18362.1139)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @mkarolin

@NejcZdovc
Copy link
Contributor

expected as we didn't order translations yet

@btlechowski
Copy link

btlechowski commented Jan 18, 2021

Verification passed on

Brave 1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
Revision 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Polish
image

French
image

German
image


Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.85 Chromium: 88.0.4324.89 (Official Build) (x86_64)
--- | ---
Revision | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS | macOS Version 11.1 (Build 20C69)
Germany Russia Japan
Bildschirmfoto 2021-01-18 um 7 21 30 PM Снимок экрана 2021-01-18 в 7 22 51 PM スクリーンショット 2021-01-18 午後7 24 05

Verification passed on


Brave | 1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
-- | --
Revision | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS | Windows 10 OS Version 2004 (Build 19041.746)


Germany:

image

Kannada
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants