Shields global settings can't be changed in private windows

[GeetaSarvadnya]

Description

Global shield settings are not retained for Private tabs

Steps to Reproduce

1. Clean profile on 0.55.18
2. Change Default Global Shields settings for Adblocker/Cookie/Fingerprint
3. Open any site in normal tab
4. Check whether Global shield settings are retained for normal tabs
5. Open any site in Private tab
6. Check whether Global shield settings are retained for Private tabs
7. Observe that Global shield settings are not retained for PT

Actual result:

Global shield settings are not retained for Private tabs

Expected result:

Global shield settings should retained for Normal and Private tabs

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Windows

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? No
• Does it reproduce on browser-laptop? No

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? NA
• Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@btlechowski Thanks for Reproducing the issue on Windows 7

@kjozwiak @LaurenWags @srirambv @btlechowski

[GeetaSarvadnya]

#1641 #1712

[simonhong]

I think this is expected behavior because private window uses off the record profile.
Tor window is same as private window. It also uses off the record profile.
Do we also want to retain shields settings on tor and private window? @bsclifton

[bsclifton]

Possibly related: #1373

[Brave-Matt]

+1 from Reddit: https://www.reddit.com/r/brave_browser/comments/9r1khf/cant_login_to_google_account_on_incognito/

[tildelowengrimm]

I feel like the actual bug here is that global settings are accessible from private windows, not that changes aren't persistent?

[bsclifton]

Closing as a duplicate of #1373

I'll update the issue text there to include when a public site setting doesn't exist (in which case it should inherit from the global one)