Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] some GitHub URLs missing from exclusion list #12544

Closed
LaurenWags opened this issue Nov 5, 2020 · 3 comments
Closed

[Desktop] some GitHub URLs missing from exclusion list #12544

LaurenWags opened this issue Nov 5, 2020 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

While testing #11463 I found that some GH URLs are missing from the exclusion list (found here: https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/github/utils.ts#L57-L76)

If you visit one of these pages and open the panel, you see the summary view, not the publisher view. These excluded pages should show github.com as the publisher.

Steps to Reproduce

  1. Have rewards enabled
  2. Navigate to a page like:
    GitHub.com/features/code-review
    github.com/security
    github.com/collections
  3. Open panel

Actual result:

missing - features

missing-security

missing-collections

Expected result:

Panel should show github.com:
login

as it does for sites on this list:
Screen Shot 2020-11-05 at 12 29 21 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a 1.16.x doesn't have the exclusion list from greaselion
  • Can you reproduce this issue with the beta channel? yes 1.17.x
  • Can you reproduce this issue with the nightly channel? yes 1.18.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @NejcZdovc @emerick

@Miyayes Miyayes added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jul 20, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jul 20, 2022

Will assign a P5 for now since Github is currently disabled for Creators in any case.

@emerick
Copy link
Contributor

emerick commented Aug 1, 2022

This seems to be working correctly, pelase reopen though if I'm missing something.

@emerick emerick closed this as completed Aug 1, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 2, 2022
@LaurenWags
Copy link
Member Author

Verified using

Brave | 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | macOS Version 12.5.1 (Build 21G83)

Verified STR and paths listed in #12544 (comment).
Verified panel showed as expected for listed paths:

github.com/features/code-review github.com/security github.com/collections
1 2 3

Also spot checked list of paths from https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/github/utils.ts#L40-L60 and confirmed panel was expected for those as well:

github.com/about github.com/marketplace github.com/team
4 5 6

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants