URL bar notifications are invisible with Light theme

[btlechowski]

Steps to Reproduce

1. Clean developer build install (make sure Dark theme is used)
2. Change the theme to Light in chrome://settings/
3. Go to http://homestarrunner.com/
4. (optional) The 'Plugin blocked' message is briefly shown so reload if needed

Actual result:

Briefly 'Plugin blocked' text in URL bar is shown
The 'Plugin blocked' message is invisible in with URL bar
mouseover, click does not change the state

Expected result:

'Plugin blocked' message is visible

Reproduces how often:

always

Brave version (chrome://version info)

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

Reproducible on current release:

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

Reproduced by @srirambv on Linux
Reproduced by @kjozwiak on Mac

cc @LaurenWags @GeetaSarvadnya

[kjozwiak]

Happens with Widevine, autoplay & plugin blocked notifications.

[petemill]

I cannot reproduce on mac FYI. Can you confirm on that platform @kjozwiak

[petemill]

Can also confirm that this is when starting the browser that is already in light mode, and not changing from dark to light before running the steps?

[kjozwiak]

@petemill I can still reproduce the issue on macOS 10.13.6 x64 using the following:

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}

STR:

• launch 0.55.6 Chromium: 70.0.3538.16 with a brand new profile, should start with the dark theme
• go into chrome://settings and change the theme from Default -> Light
• open a new tab and load netflix.com and you'll notice that the Widevine message won't be visible

Example:

Can also confirm that this is when starting the browser that is already in light mode, and not changing from dark to light before running the steps?

Confirmed, this only happens when you start with the Dark theme and switch over to the Light theme. The following case works as expected:

• launch 0.55.6 Chromium: 70.0.3538.16 with a brand new profile, should start with the dark theme
• go into chrome://settings and change the theme from Default -> Light
• restart the browser
• open a new tab and load netflix.com and you'll see the message as expected

[btlechowski]

@petemill Apologies. I have just checked my notes and for some reason first two steps are not in the bug report. I updated the issue.

[bbondy]

@petemill I moved this into 0.55.x since this is prety bad.

[LaurenWags]

Verified passed with

Brave	0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

• Verified with STR from description
• Verified Plugin, Widevine, and Autoplay notifications
• Verified for dark -> light theme and light -> dark theme changes

Verification passed on

Brave	0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Windows 7

Tested Plugin, Widevine, and Autoplay notifications for different themes

Verification Passed on

Brave	0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Linux