-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing google sign in modal from chrome://devices #1279
Comments
On second thought, probably a good idea to remove this sooner than later due to the Google automatically logging folks into their browser without asking issue that's pretty hot right now. |
brave/brave-core@a0609ec just removes the 'sign in' link but does it make sense to show the rest of the sentence? |
We should probably remove the full line of text, thanks for catching it. |
Please do a separate PR for that, you can link it to the same issue. |
The 'Add printers' button also redirects to a Google sign in page. I guess the 'Classic printers' div should be deleted entirely, right @bbondy? |
Once you get this popup with |
Went through verification using the following build under
Verification passed on
Verification Passed on
|
Description
We should remove the Google
Sign In
modal window underchrome://devices
which also includes Google branding. Because this is pretty buried, I don't think we need to fix it for0.55.x
but should remove this before releasing1.0.
.Steps to Reproduce
b-c
and loadchrome://devices
sign in
and you'll get a Google sign in modal that includes Google brandingActual result:
Expected result:
Clicking on
Sign in
underchrome://devices
shouldn't launch the Google modal which also includes Google branding.Reproduces how often:
100% reproducible when going through the above STR.
Brave version (chrome://version info)
Reproducible on current release:
Yes, currently reproducible with
0.55.6 Chromium: 70.0.3538.16
which is the current release.The text was updated successfully, but these errors were encountered: