Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gaia URL to be no-thanks.invalid #1312

Closed
bbondy opened this issue Sep 27, 2018 · 4 comments · Fixed by brave/brave-core#512
Closed

Change gaia URL to be no-thanks.invalid #1312

bbondy opened this issue Sep 27, 2018 · 4 comments · Fixed by brave/brave-core#512

Comments

@bbondy
Copy link
Member

bbondy commented Sep 27, 2018

We don't want gaia requests going to Google, so we should change the request endpoint from accounts.google.com to https://no-thanks.invalid

@LaurenWags
Copy link
Member

LaurenWags commented Sep 27, 2018

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Used test plan from brave/brave-core#512 to verify that on Dev build (0.55.6) prior to fix the gaia URL displays accounts.google.com/etc... (ex. Line 17)
screen shot 2018-09-27 at 12 22 12 pm

Verified with 0.55.10 Beta build the gaia URL displays no-thanks.invalid/etc... (ex. Line 17) and that accounts.google.com/ListAccounts/etc... link is not found.
screen shot 2018-09-27 at 12 22 38 pm

Additionally, verified gmail (opening emails, clicking on links), drive, google+, worked without issue.

Verification Passed on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Linux
  • Verified all gaia links replaced with no-thanks.invalid/ on beta
    image
  • Verified all gaia links retained on dev
    image
  • Verified remained logged into Google account on Beta without any problems
  • Verified other Google services worked without any issue on beat

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Using the STR form the PR, ensured that the following links are being used under 0.55.10 Chromium: 70.0.3538.22:

 {"params":{"load_flags":0,"method":"POST","upload_id":"0","url":"https://no-thanks.invalid/ListAccounts?gpsia=1&source=durations_metrics,counter:0,load_time_ms:113&json=standard"},"phase":1,"source":{"id":73,"type":1},"time":"330451300","type":97}

Also verified that before the fix under 0.55.6 Chromium: 70.0.3538.16, the following was being used:

 {"params":{"load_flags":0,"method":"POST","upload_id":"0","url":"https://accounts.google.com/ListAccounts?gpsia=1&source=durations_metrics,counter:0,load_time_ms:103&json=standard"},"phase":1,"source":{"id":73,"type":1},"time":"331730721","type":97}

Additionally, went through the following cases using 0.55.10 Chromium: 70.0.3538.22:

  • ensured Gmail worked once logged into an account
  • ensured GCal worked once logged into an account
  • ensured YouTube worked once logged into an account
  • ensured that GDrive worked once logged into an account
  • ensured that I can login into multiple Google accounts
  • ensured that I cans switch between multiple accounts
  • ensured that browsing through Google Accounts and changing a few settings works without issues

Verification passes on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows 7

verified accounts.google.com is replaced with no-thanks.invalid
verified google services are still accessible.

@RyanJarv
Copy link
Contributor

RyanJarv commented Jan 8, 2020

Got a notice from little snitch that a request was being made to no-thanks.invalid just now. Seems like this domain shouldn't exist but was resolving to 23.195.69.106 and 23.202.231.166 on my computer. I'm guessing this was due to my providers DNS resolving invalid domains. Unsure if this is an issue but wanted to make note of it at least.

$ host no-thanks.invalid
no-thanks.invalid has address 23.202.231.166
no-thanks.invalid has address 23.195.69.106
Host no-thanks.invalid not found: 3(NXDOMAIN)

(Bit confused why I get a few IP's here and a NXDOMAIN but this was copy/pasted.)

@knightwolfjk
Copy link

@RyanJarv FWIW here's my output of same

# host no-thanks.invalid
Host no-thanks.invalid not found: 3(NXDOMAIN)

@RyanJarv
Copy link
Contributor

@knightwolfjk

NXDOMAIN behavior is DNS provider dependent, I would say it's best not to rely on NXDOMAIN being returned if initiating the request is a concern.

cc: @bbondy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants