Empty IPFS cache missing from Delete browsing data dialog #13302

da2x · 2020-12-27T01:49:17Z

Steps to Reproduce

Browse some ipfs://hashes
Go to brave://settings/clearBrowserData
Delete the browsing cache using the dioalog.

Expected result:

It should garbage collect the IPFS repository. More details.

Actual result:

IPFS data remains in the IPFS repo/cache on disk.

Reproduces how often:

Every time.

Brave version (brave://version info)

1.19.67

Version/Channel Information:

Beta only.

Other Additional Information:

Issuing a call to run the IPFS garbage collector should do the trick.

diracdeltas · 2020-12-30T22:14:23Z

this is a great idea; cc @yrliou

diracdeltas · 2021-01-11T21:26:41Z

should this be an extra switch or just be cleared whenever the user selects clear cache? i slightly prefer the latter.

da2x · 2021-01-11T21:46:50Z

I can’t see any reason to make it a separate option. However, it might be good to change the string to say something like "Clear browsing and IPFS caches," but only when IPFS is enabled.

yrliou · 2021-01-13T00:52:05Z

Note that these options chromium support could be deleted for a specific time range, but it is not something ipfs repo gc command supports, I think for now we'll just run ipfs repo gc when Cached images and files option is selected which will purge the whole cache expect for pinned files and won't support time-ranged deletion.

yrliou · 2021-01-14T23:30:58Z

Test plan specified in brave/brave-core#7578

kjozwiak · 2021-01-19T00:09:19Z

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.85 Chromium: 88.0.4324.89 (Official Build) (x86_64)
--- | ---
Revision | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS | macOS Version 11.1 (Build 20C69)

loaded https://dweb.link/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR and enabled IPFS
ensured that Method to resolve IPFS resources is set as Local Node under brave://settings/extensions
ensured that the local node was running via brave://ipfs

kjozwiak@Kamils-MacBook-Pro 1.0.3 % ./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 28
RepoSize:   53568
StorageMax: 1000000000
RepoPath:   /Users/kjozwiak/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

opened ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and waited till the entire website loaded

kjozwiak@Kamils-MacBook-Pro 1.0.3 % ./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 348
RepoSize:   3493272
StorageMax: 1000000000
RepoPath:   /Users/kjozwiak/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

cleared data via brave://settings/clearBrowserData and ensured that Cached images and files was not selected

kjozwiak@Kamils-MacBook-Pro 1.0.3 % ./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 348
RepoSize:   3493272
StorageMax: 1000000000
RepoPath:   /Users/kjozwiak/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

cleared data via brave://settings/clearBrowserData and ensured that Cached images and files was selected this time around

kjozwiak@Kamils-MacBook-Pro 1.0.3 % ./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 13
RepoSize:   60667
StorageMax: 1000000000
RepoPath:   /Users/kjozwiak/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

opened ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and waited till the entire website loaded

kjozwiak@Kamils-MacBook-Pro 1.0.3 % ./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 329
RepoSize:   3442996
StorageMax: 1000000000
RepoPath:   /Users/kjozwiak/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

went into brave://settings/clearBrowserData and selecting Cached images and files under the On Exit tab
closed the browser and waiting ~20s
re-launched the browser
went into brave://ipfs and loaded the local node by selecting Start
waited till the node connected to several peers

kjozwiak@Kamils-MacBook-Pro 1.0.3 % ./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 13
RepoSize:   70273
StorageMax: 1000000000
RepoPath:   /Users/kjozwiak/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

Verification passed on

Brave	1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
Revision	4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS	Ubuntu 18.04 LTS

loaded https://dweb.link/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR and enabled IPFS
ensured that Method to resolve IPFS resources is set as Local Node under brave://settings/extensions
ensured that the local node was running via brave://ipfs

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 28
RepoSize:   178771
StorageMax: 1000000000
RepoPath:   /home/bartlomiej/.config/BraveSoftware/Brave-Browser/brave_ipfs

opened ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and waited till the entire website loaded

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 49
RepoSize:   1109311
StorageMax: 1000000000
RepoPath:   /home/bartlomiej/.config/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

cleared data via brave://settings/clearBrowserData and ensured that Cached images and files was not selected

Ipfs data was not deleted

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 49
RepoSize:   1109311
StorageMax: 1000000000
RepoPath:   /home/bartlomiej/.config/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

cleared data via brave://settings/clearBrowserData and ensured that Cached images and files was selected this time around

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 13
RepoSize:   254742
StorageMax: 1000000000
RepoPath:   /home/bartlomiej/.config/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

opened ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and waited till the entire website loaded

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 326
RepoSize:   4601493
StorageMax: 1000000000
RepoPath:   /home/bartlomiej/.config/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

went into brave://settings/clearBrowserData and selecting Cached images and files under the On Exit tab
closed the browser and waiting ~20s
re-launched the browser
went into brave://ipfs and loaded the local node by selecting Start
waited till the node connected to several peers

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 13
RepoSize:   1243533
StorageMax: 1000000000
RepoPath:   /home/bartlomiej/.config/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@10

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.19.86 Chromium: 88.0.4324.96 (Official Build) (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2009 (Build 19042.746)

loaded https://dweb.link/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR and enabled IPFS
ensured that Method to resolve IPFS resources is set as Local Node under brave://settings/extensions
ensured that the local node was running via brave://ipfs

C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3
λ go-ipfs_v0.7.0_windows-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 28
RepoSize:   55836
StorageMax: 1000000000
RepoPath:   C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\brave_ipfs
Version:    fs-repo@10

opened ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and waited till the entire website loaded

C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3
λ go-ipfs_v0.7.0_windows-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 344
RepoSize:   3437479
StorageMax: 1000000000
RepoPath:   C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\brave_ipfs
Version:    fs-repo@10

cleared data via brave://settings/clearBrowserData and ensured that Cached images and files was not selected

C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3
λ go-ipfs_v0.7.0_windows-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 344
RepoSize:   3437479
StorageMax: 1000000000
RepoPath:   C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\brave_ipfs
Version:    fs-repo@10

cleared data via brave://settings/clearBrowserData and ensured that Cached images and files was selected this time around

C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3
λ go-ipfs_v0.7.0_windows-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 13
RepoSize:   45791
StorageMax: 1000000000
RepoPath:   C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\brave_ipfs
Version:    fs-repo@10

opened ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and waited till the entire website loaded

C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3
λ go-ipfs_v0.7.0_windows-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 329
RepoSize:   3424858
StorageMax: 1000000000
RepoPath:   C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\brave_ipfs
Version:    fs-repo@10

went into brave://settings/clearBrowserData and selecting Cached images and files under the On Exit tab
closed the browser and waiting ~20s
re-launched the browser
went into brave://ipfs and loaded the local node by selecting Start
waited till the node connected to several peers

C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3
λ go-ipfs_v0.7.0_windows-amd64 --api=/ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 13
RepoSize:   77817
StorageMax: 1000000000
RepoPath:   C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\brave_ipfs
Version:    fs-repo@10

da2x added the OS/Desktop label Dec 27, 2020

bsclifton added the feature/web3/ipfs label Dec 27, 2020

diracdeltas added the privacy label Dec 30, 2020

pes10k added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 5, 2021

yrliou self-assigned this Jan 11, 2021

yrliou mentioned this issue Jan 14, 2021

Clear IPFS cache when clearing browsing data brave/brave-core#7578

Merged

23 tasks

yrliou added QA/Test-Plan-Specified QA/Yes labels Jan 14, 2021

yrliou added the release-notes/include label Jan 14, 2021

yrliou closed this as completed in brave/brave-core#7578 Jan 15, 2021

yrliou added this to the 1.21.x - Nightly milestone Jan 15, 2021

This was referenced Jan 15, 2021

Clear IPFS cache when clearing browsing data (uplift to 1.20.x) brave/brave-core#7616

Merged

Clear IPFS cache when clearing browsing data (uplift to 1.19.x) brave/brave-core#7617

Merged

kjozwiak modified the milestones: 1.21.x - Nightly, 1.19.x - Release Jan 18, 2021

kjozwiak added the QA Pass-macOS label Jan 19, 2021

This was referenced Jan 19, 2021

crash when clearing "Cached images and files" while IPFS enabled/running #13625

Closed

Release Notes for 1.19.x Release #1 (Release Channel) #13648

Closed

btlechowski added the QA Pass-Linux label Jan 19, 2021

kjozwiak removed the release-notes/include label Jan 19, 2021

kjozwiak added release-notes/exclude QA Pass-Win64 labels Jan 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Empty IPFS cache missing from Delete browsing data dialog #13302

Empty IPFS cache missing from Delete browsing data dialog #13302

da2x commented Dec 27, 2020 •

edited

Loading

diracdeltas commented Dec 30, 2020

diracdeltas commented Jan 11, 2021 •

edited

Loading

da2x commented Jan 11, 2021

yrliou commented Jan 13, 2021

yrliou commented Jan 14, 2021

kjozwiak commented Jan 19, 2021 •

edited

Loading

Empty IPFS cache missing from Delete browsing data dialog #13302

Empty IPFS cache missing from Delete browsing data dialog #13302

Comments

da2x commented Dec 27, 2020 • edited Loading

Steps to Reproduce

Expected result:

Actual result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

diracdeltas commented Dec 30, 2020

diracdeltas commented Jan 11, 2021 • edited Loading

da2x commented Jan 11, 2021

yrliou commented Jan 13, 2021

yrliou commented Jan 14, 2021

kjozwiak commented Jan 19, 2021 • edited Loading

da2x commented Dec 27, 2020 •

edited

Loading

diracdeltas commented Jan 11, 2021 •

edited

Loading

kjozwiak commented Jan 19, 2021 •

edited

Loading