Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on ipfs_client_updater component being loaded for clearing IPFS cache #13605

Closed
yrliou opened this issue Jan 15, 2021 · 0 comments · Fixed by brave/brave-core#8104
Closed

Don't rely on ipfs_client_updater component being loaded for clearing IPFS cache #13605

yrliou opened this issue Jan 15, 2021 · 0 comments · Fixed by brave/brave-core#8104
Assignees
@spylogsster
Labels
feature/web3/ipfs OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.23.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Jan 15, 2021

brave/brave-core#7578 (review)
This is a follow up issue to fix the case that's been brought up in the review.
Currently we relied on ipfs_client_updater component being loaded to be able to get the executable path from it.
We should keep the last known good path maybe in a pref for us to use, so we could run ipfs repo gc even when the component is not yet loaded due to lazy loading.
cc @bbondy
@yrliou yrliou changed the title Run clear IPFS cache when ipfs_client_updater component is not yet loaded Don't rely on ipfs_client_updater component being loaded for clearing IPFS cache Jan 15, 2021
@yrliou yrliou self-assigned this Jan 15, 2021
@yrliou yrliou mentioned this issue Jan 15, 2021
Merged
23 tasks
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 26, 2021
@spylogsster spylogsster assigned spylogsster and unassigned yrliou Mar 1, 2021
@spylogsster spylogsster mentioned this issue Mar 2, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.23.x - Nightly milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging a pull request may close this issue.

Save ipfs executable path brave/brave-core
3 participants
@bbondy @spylogsster @yrliou