Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save ipfs executable path #8104

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Save ipfs executable path #8104

merged 1 commit into from
Mar 4, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 2, 2021

Resolves brave/brave-browser#13605

Replaced boolean kIPFSBinaryAvailable by kIPFSBinaryPath that contains file path, the path is retrieved from OnExecutableReady and used inside IpfsService

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Instal IpfsSerivce library
  • Restart browser
  • Go to settings and clear browser cache
  • Ipfs binary should be called, you can see it in logs or in Task Manager

@spylogsster spylogsster requested a review from bbondy March 2, 2021 10:21
@spylogsster spylogsster force-pushed the save-ipfs-executable-path branch 2 times, most recently from 5d6a741 to 48baa52 Compare March 2, 2021 10:44
@bbondy
Copy link
Member

bbondy commented Mar 3, 2021

@yrliou could you review?

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spylogsster spylogsster merged commit a4beb0d into master Mar 4, 2021
@spylogsster spylogsster deleted the save-ipfs-executable-path branch March 4, 2021 19:00
@spylogsster spylogsster added this to the 1.23.x - Nightly milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't rely on ipfs_client_updater component being loaded for clearing IPFS cache
3 participants