Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://settings sidenav accessibility and Brave design system light/dark theming, icons, typography #13688

Closed
bbondy opened this issue Jan 20, 2021 · 4 comments
Closed

brave://settings sidenav accessibility and Brave design system light/dark theming, icons, typography #13688

bbondy opened this issue Jan 20, 2021 · 4 comments
Assignees
@karenkliu
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. OS/Desktop

Comments

@bbondy
Copy link
Member

bbondy commented Jan 20, 2021 •
edited by karenkliu
Loading

Edit/Note: @kliu to tighten up this issue to cover Theming, Typography, and Side Nav. Other issues will be covered in #16621

Description

Settings is not using latest design system light/dark theme colors, typography, and icons.

Designs

Improve the accessibility of the sidenav by using interaction states from the design system.
image

Bring the settings page in line with the Brave design system:
-update all typography to Poppins
-update icons with ones from our Brave icon library
-update dark theme colors
-remove shadows from the cards

image

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=359%3A9749
@rebron rebron added the design A design change, especially one which needs input from the design team label Jan 21, 2021
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 25, 2021
@karenkliu karenkliu changed the title Have a section in chrome://settings for Tor Creator Tor and Crypto Wallets section in chrome://settings, icon updates Jan 27, 2021
@karenkliu karenkliu changed the title Creator Tor and Crypto Wallets section in chrome://settings, icon updates Create Tor and Crypto Wallets section in chrome://settings, icon updates Jan 27, 2021
@karenkliu karenkliu mentioned this issue Jan 27, 2021
Closed
@karenkliu
Copy link

Designs added!

@karenkliu karenkliu removed their assignment Jan 28, 2021
@bbondy
Copy link
Member Author

bbondy commented Jan 28, 2021

I think IPFS and Crypto Wallets should be close together and in the same section. Did you want them both in Additional Settings @karenkliu ?

@karenkliu
Copy link

@rebron Do you want to bump Crypto Wallets up above IPFS?

@bbondy bbondy changed the title Create Tor and Crypto Wallets section in chrome://settings, icon updates Create Tor settings section, icon updates, and other updates Feb 9, 2021
@bbondy bbondy mentioned this issue Feb 9, 2021
Closed
@karenkliu karenkliu mentioned this issue Feb 12, 2021
Closed
@rebron rebron mentioned this issue Mar 9, 2021
Closed
This was referenced May 28, 2021
Closed
Closed
@rebron rebron mentioned this issue Jun 25, 2021
Open
13 tasks
@karenkliu karenkliu changed the title Create Tor settings section, icon updates, and other updates brave://settings sidenav accessibility and Brave design system light/dark theming, icons, typography Jun 25, 2021
@karenkliu karenkliu mentioned this issue Jul 12, 2021
Closed
@rebron rebron added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Nov 1, 2022
@rebron
Copy link
Collaborator

rebron commented Nov 1, 2022

Closing as stale in favor of #24216 which was fixed in 1.44.x.

@rebron rebron closed this as completed Nov 1, 2022
@rebron rebron removed feature/tor design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @karenkliu @rebron