Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enable/disable search tabs button #16007

Closed
Brave-Matt opened this issue May 20, 2021 · 38 comments · Fixed by brave/brave-core#9570
Closed

Add setting to enable/disable search tabs button #16007

Brave-Matt opened this issue May 20, 2021 · 38 comments · Fixed by brave/brave-core#9570
Assignees
Labels
design A design change, especially one which needs input from the design team feature/settings feature/tabs-bar OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Brave-Matt commented May 20, 2021

Description

image

Chrome has removed this flag in Chromium v91.0.4472.77. Some of our users lean more towards "minimalists" and would prefer the option to hide/disable this option if possible.

Designs

Add 'Show search tabs button' under 'Hide Brave Rewards' toggle. Create new subsections for 'Bookmarks bar' 'Toolbar' and 'Typography'

image

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=808%3A9463

@Tonev
Copy link
Contributor

Tonev commented May 27, 2021

+1

It's frustrating we can't disable a feature we don't want to use.

@marcelduin
Copy link

marcelduin commented May 27, 2021

+1

When introducing a button in such a prominent location, please also add the option to remove it.

@Tonev
Copy link
Contributor

Tonev commented May 28, 2021

The feature is being actively discussed on Reddit as well: https://www.reddit.com/r/brave_browser/comments/nmhdsf/what_the_fuck_is_this_thing_and_how_do_i_remove_it/

@mattspew
Copy link

+1

Don't need or want this button.

@Kil0grm
Copy link

Kil0grm commented May 28, 2021

+1

When introducing a button in such a prominent location, please also add the option to remove it.

Better yet, don't introduce random buttons in any location. I mean holly shit, what year is this. Clean uis are an absolute must.

@vuon9
Copy link

vuon9 commented May 28, 2021

In the past, the hover card on tab have released as enabled as default without a flag to toggle. This problem is happened again with the feature. Along with that, a promoted for search tab. 😂

@manikandancode
Copy link

manikandancode commented May 28, 2021

Add a option to remove the button completely

[OR/AND]

Add a option to show/hide below components on that field

  1. search field [OR/AND]
  2. Open tabs [OR/AND]
  3. Recently closed tabs

@joaovgp
Copy link

joaovgp commented May 28, 2021

+1
along with being able to remove it, please re-enable the feature to REMOVE Tab Hover Cards

@joaovgp
Copy link

joaovgp commented May 28, 2021

In the past, the hover card on tab have released as enabled as default without a flag to toggle. This problem is happened again with the feature. Along with that, a promoted for search tab. 😂

its so f*ing annoying

@realzombiegeek
Copy link

Make it go away!

@sinankizar
Copy link

There is no need to use such feature. At least for me it is very very unnecessary. Please enable the setting so we may choose.

@Sy0xFF
Copy link

Sy0xFF commented May 28, 2021

+1

1 similar comment
@owlw
Copy link

owlw commented May 28, 2021

+1

@richardwarriner
Copy link

+1
As a general rule, every time something is added to the UI make sure there is also a way to turn it off

I cant ever imagine a scenario where I would want to search across tabs

@Brave-Matt
Copy link
Author

Several Community members requesting this here:
https://community.brave.com/t/how-do-i-disable-the-search-tab/253756/4

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. design A design change, especially one which needs input from the design team labels May 28, 2021
@karenkliu
Copy link

Added the toggle to address this in #13688.

@bstin
Copy link

bstin commented May 30, 2021

+1
along with being able to remove it, please re-enable the feature to REMOVE Tab Hover Cards

Yes, I realize that chrome enabled these by default, but Brave devs please help unclutter the UI by removing these useless features.
"Searching" your tabs and giving you "tab hover cards" are just useless clutter-UI. Nothing of value is gained.

@Tonev
Copy link
Contributor

Tonev commented May 30, 2021

+1
along with being able to remove it, please re-enable the feature to REMOVE Tab Hover Cards

Yes, I realize that chrome enabled these by default, but Brave devs please help unclutter the UI by removing these useless features.
"Searching" your tabs and giving you "tab hover cards" are just useless clutter-UI. Nothing of value is gained.

#9906

@someguy9
Copy link

Still can't believe Chromium added this by default

@mac-repo-001
Copy link

Another usesless feature that clutters the interface. Please add option to disable it.

@kyleb1111
Copy link

This is F*in ridiculous. Why would you add this without an option to disable it? Nobody asks for this. Seriously guys, come on.

+1 to everything said here.

@Lionel2001
Copy link

Any feature that is added (Search Tabs) should have an equivalent remove or disable option. This would be considered good design?

@charbelnicolas
Copy link

Also, if you choose the gtk theme on Linux the button shifts to the left and is no longer centered with the hamburger menu :( (already reported it to chromium btw).

@JimBreton
Copy link

+1
along with being able to remove it, please re-enable the feature to REMOVE Tab Hover Cards

Yes, I realize that chrome enabled these by default, but Brave devs please help unclutter the UI by removing these useless features.
"Searching" your tabs and giving you "tab hover cards" are just useless clutter-UI. Nothing of value is gained.

Going to go out on a limb here; personally, I love the 'Search tabs' button, as it fulfills 75% of the usefulness of Firefox's Ctrl+Tab tab switching behavior and this was one of the things I really missed when switching over. I think this feature is great. And as a keyboard shortcut junkie AND a 'many open tabs' junkie this is very useful.

I realize this is a matter of opinion, and I don't disagree that it would be nice to be able to disable it, but personally I'd rather see limited Dev resources spent elsewhere vs. fighting upstream/mainstream Chromium UI changes.

@seanbebliss
Copy link

Version 1.25.70 Chromium: 91.0.4472.77 (Official Build) (64-bit) (p.s. - NEVER UPDATE AGAIN INVASIVE CIRCLE TRIANGLE ICON HATE SEEING IT MAKE IT GO AWAY! ROLL BACK TOO TECHNICAL (where easy install old version? NONE!!!!). YOU BREAKING MY MIND STUPED ALWAYS VISIBLE BUTTON!)

@rebron rebron changed the title Surface setting to enable/disable search tabs button Add setting to enable/disable search tabs button Jun 25, 2021
@EyeSalt
Copy link

EyeSalt commented Jul 3, 2021

It's been over a month and it looks like we are held captive at their whims.. if it’s not fixed soon I will have no option but to use an earlier portable version without this feature. I don’t want to have to do this, so please FIX this.

@y4rr
Copy link

y4rr commented Jul 5, 2021

Brave is becoming Chrome. I'm switching to Vivaldi lol.

@MyCodeIsntWorking
Copy link

+1

Remove this button pls or give us an option to disable this crap.

@DevilEars
Copy link

+1
Pretty please. It was possible to remove this featuritis abomination with the flag:
chrome://flags/#enable-tab-search

That flag is no longer available, so now unfortunately Brave is less user-friendly due to a Chromium update.

@bsclifton
Copy link
Member

I believe @nullhook is working on this now (guessing it'll go under brave://settings/appearance)

@bsclifton
Copy link
Member

bsclifton commented Aug 2, 2021

Adding missing milestone 😄 and other labels (QA/yes, release-notes/include)

@stephendonner
Copy link

stephendonner commented Aug 3, 2021

Verified FIXED using

Brave 1.29.45 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 12.0 (Build 21A5294g)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/appearance
  4. saw Show Search Tabs Button is toggled to on by default, and the icon for the feature is on the top right of the tab strip
  5. confirmed that toggling Show Search Tabs Button works in real-time and doesn't require browser restart
default off
Screen Shot 2021-08-02 at 5 22 13 PM Screen Shot 2021-08-02 at 5 26 55 PM

Verification passed on

Brave 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Ubuntu 18.04 LTS

Verified Show Search Tabs Button is toggled to on by default, and the icon for the feature is on the top right of the tab strip

enabled:
image

Verified that toggling Show Search Tabs Button works in real-time and doesn't require browser restart

disabled:
image

------

Verification passed on

Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

  1. opened brave://settings/appearance
  2. saw Show Search Tabs Button is toggled to on by default, and the icon for the feature is on the top right of the tab strip
  3. confirmed that toggling Show Search Tabs Button works in real-time and doesn't require a browser restart
default off
image image

@karenkliu
Copy link

This setting should be sentence case.

cc @rmcfadden3

@stephendonner
Copy link

This setting should be sentence case.

cc @rmcfadden3

oops, sorry, forgot to link #17310 back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/settings feature/tabs-bar OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.