Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation on Welcome page states that you can earn tokens by automatically supporting the content creators #13708

Closed
btlechowski opened this issue Jan 21, 2021 · 4 comments

Comments

@btlechowski
Copy link

It states:
Zarabiaj tokeny poprzez oglądanie Brave Private Ads oraz automatyczne wspieranie twórców treści.
Which translates to
Earn tokens by viewing Brave Private Ads and by supporting content creators automatically

I think the text in English should be more obvious so that the translators don't make that mistake.
I would say the best solution would be to change the English string so the intent is more obvious:

Earn tokens by viewing Brave Private Ads.
Support content creators automatically.

Steps to Reproduce

  1. Clean profile
  2. Run Brave in Polish (PL) locale
  3. On Welcome UI (brave://welcome), open Rewards onboarding

Actual result:

Polish translation on Welcome page states that Polish suggests that you can earn tokens by automatically supporting
image

Expected result:

Polish translation on Welcome page states the intent accurately.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.21.18 Chromium: 88.0.4324.96 (Oficjalna wersja) nightly (64-bitowa)
Wersja 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @mkarolin @rebron @brave/legacy_qa

@btlechowski
Copy link
Author

@mkarolin suggested a different translation here: #13649 (comment), but it includes some words that the English translation on Welcome page doesn't have.
Zarabiaj tokeny, oglądając reklamy z poszanowaniem prywatności i automatycznie wspieraj ulubione strony oraz twórców treści

On welcome page, it would be something like this, which is better:
Zarabiaj tokeny, oglądając reklamy i automatycznie wspieraj twórców treści

@rebron
Copy link
Collaborator

rebron commented Jan 26, 2021

cc: @karenkliu updated strings in the default browser work.

@karenkliu
Copy link

Set Brave as default browser:

String on the Brave Rewards panel should be:

Earn tokens by viewing Brave Private Ads and support content creators automatically.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 2, 2021
@btlechowski
Copy link
Author

Verification passed on

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

This issue is no longer valid as we don't have these strings on Welcome pages:

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants