Set default browser first_run dialog on macOS and Linux

[karenkliu]

Description

We need to update the onboarding flow with:

• More aggressive pitch for set default browser for increased retention and engagement

Design for MacOS

Enable the first_run dialog that comes with Chromium. This dialog shows before the browser is launched. It comes with checkboxes for set default browser and send crash reports. Change the text to say 'private product analytics'.

Follow-up for these designs in this issue: #14183

Assets

Figma: https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/?node-id=146%3A0

[karenkliu]

Removed Yahoo from the search engine slide.

[btlechowski]

Verification passed on beta channel

Brave	1.21.47 Chromium: 88.0.4324.152 (Official Build) beta (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Linux

Verified first run dialog is shown

Verified on beta channel that the beta build was made default browser when Set Brave as your default browser is enabled
Verified default browser was not changed when Set Brave as your default browser is disabled
Verified automatic crash reporting is enabled when Help improve Brave... is enabled
Verified PPA is enabled when Help improve Brave... is enabled.

Verified automatic crash reporting is disabled when Help improve Brave... is disabled
Verified PPA is disabled when Help improve Brave... is disabled. Logged #14160

Verification passed on dev channel

Brave	1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Ubuntu 18.04 LTS

Verified first run dialog is shown

Verified on dev channel that the dev build was made default browser when Set Brave as your default browser is enabled
Verified default browser was not changed when Set Brave as your default browser is disabled
Verified automatic crash reporting is enabled when Help improve Brave... is enabled
Verified PPA is enabled when Help improve Brave... is enabled.

Verified automatic crash reporting is disabled when Help improve Brave... is disabled
Verified PPA is disabled when Help improve Brave... is disabled. Logged #14160

Verification passed on nightly channel

Brave	1.22.23 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision	0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS	Ubuntu 18.04 LTS

Verified first run dialog is shown

Verified on nightly channel that the nightly build was made default browser when Set Brave as your default browser is enabled
Verified default browser was not changed when Set Brave as your default browser is disabled
Verified automatic crash reporting is enabled when Help improve Brave... is enabled
Verified PPA is enabled when Help improve Brave... is enabled.

Verified automatic crash reporting is disabled when Help improve Brave... is disabled
Verified PPA is disabled when Help improve Brave... is disabled. Logged #14160

Verification passed on release channel

Brave	1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	Ubuntu 18.04 LTS

Verified first run dialog is shown

Verified on release channel that the release build was made default browser when Set Brave as your default browser is enabled
Verified default browser was not changed when Set Brave as your default browser is disabled
Verified automatic crash reporting is enabled when Help improve Brave... is enabled
Verified automatic crash reporting is disabled when Help improve Brave... is disabled

---

Verified on the following channels:

Brave	1.22.27 Chromium: 89.0.4389.48 (Official Build) nightly (x86_64)
Revision	0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS	macOS Version 10.15.7 (Build 19H512)

Nightly (x64/intel)

Verified test plan from brave/brave-core#7700.

Confirmed first run dialog is shown:

Confirmed when using Nightly channel that I was prompted about changing my default browser when "Set Brave as your default browser" was selected:

Confirmed that Nightly build was made default browser when selected on OS-level prompt.
Confirmed automatic crash reporting is enabled when "Help improve Brave..." is selected.
Confirmed P3A is enabled when Help improve Brave... is selected.

Example	Example

Confirmed I was not prompted about changing my default browser when "Set Brave as your default browser" is not selected.
Confirmed automatic crash reporting is disabled when Help improve Brave... is not selected.
Confirmed P3A is disabled when Help improve Brave... is not selected.

Example	Example	Example

Brave	1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 10.15.7 (Build 19H512)

Dev (x64/intel)

Verified test plan from brave/brave-core#7700.

Confirmed first run dialog is shown:

Confirmed when using Dev channel that I was prompted about changing my default browser when "Set Brave as your default browser" was selected:

Confirmed that Dev build was made default browser when selected on OS-level prompt.
Confirmed automatic crash reporting is enabled when "Help improve Brave..." is selected.
Confirmed P3A is enabled when Help improve Brave... is selected.

Example	Example

Confirmed I was not prompted about changing my default browser when "Set Brave as your default browser" is not selected.
Confirmed automatic crash reporting is disabled when Help improve Brave... is not selected.
Confirmed P3A is disabled when Help improve Brave... is not selected.

Example	Example	Example

Brave	1.21.55 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 10.15.7 (Build 19H512)

Beta (x64/intel)

Verified test plan from brave/brave-core#7700.

Confirmed first run dialog is shown:

Confirmed when using Beta channel that I was prompted about changing my default browser when "Set Brave as your default browser" was selected:

Confirmed that Beta build was made default browser when selected on OS-level prompt.
Confirmed automatic crash reporting is enabled when "Help improve Brave..." is selected.
Confirmed P3A is enabled when Help improve Brave... is selected.

Example	Example

Confirmed I was not prompted about changing my default browser when "Set Brave as your default browser" is not selected.
Confirmed automatic crash reporting is disabled when Help improve Brave... is not selected.
Confirmed P3A is disabled when Help improve Brave... is not selected.

Example	Example	Example

Brave	1.21.55 Chromium: 88.0.4324.152 (Official Build) beta (arm64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 11.2 (Build 20D64)

Beta (arm64/M1)

Verified test plan from brave/brave-core#7700.

Confirmed first run dialog is shown:

Confirmed when using Beta channel that I was prompted about changing my default browser when "Set Brave as your default browser" was selected:

Confirmed that Beta build was made default browser when selected on OS-level prompt.
Confirmed automatic crash reporting is enabled when "Help improve Brave..." is selected.
Confirmed P3A is enabled when Help improve Brave... is selected.

Example	Example

Confirmed I was not prompted about changing my default browser when "Set Brave as your default browser" is not selected.
Confirmed automatic crash reporting is disabled when Help improve Brave... is not selected.
Confirmed P3A is disabled when Help improve Brave... is not selected.

Example	Example	Example

[btlechowski]

Set as QA/Blocked till we get a release build for 1.21.x

[btlechowski]

No longer QA/Blocked as we have a 1.21.x release build.

[stephendonner]

Verified FIXED using the testplan from brave/brave-core#7700 with:

Brave	1.21.68 Chromium: 89.0.4389.58 (Official Build) (x86_64)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	macOS Version 11.2.2 (Build 20D80)

Confirmed first run dialog is shown:

screenshot

Confirmed when using Release channel that I was prompted about changing my default browser when "Set Brave as your default browser" was selected:

screenshot

Confirmed that Release build was made default browser when selected on OS-level prompt.

Confirmed automatic crash reporting is enabled when "Help improve Brave..." is selected.

Confirmed P3A is enabled by default in brave://settings/privacy

screenshots

Confirmed I was not prompted about changing my default browser when Set Brave as your default browser is not selected.
Confirmed in the Default browser section inbrave://settings that the Make default button exists and is clickable.
Confirmed automatic crash reporting is disabled when Help improve Brave... is not selected.
Confirmed P3A remains enabled, by default, in brave://settings/privacy

screenshots

[pitsi]

I just upgraded to 1.21.x and I get the prompt ON EVERY LAUNCH. Shouldn't it be shown just once?
Debian testing/unstable x64 and x-www-browser (= the system wide setting for the default browser) is already set to brave

$ file /usr/bin/x-www-browser
/usr/bin/x-www-browser: symbolic link to /etc/alternatives/x-www-browser
$ file /etc/alternatives/x-www-browser
/etc/alternatives/x-www-browser: symbolic link to /usr/bin/brave-browser-stable

If there is a switch or a flag that can disable it, please tell me. Thank you in advance.

[matthieu-bt]

Same issue here, on Windows 10. I use Brave in private mode only. And since this morning, EVERY time I open it, I get the prompt.

[pitsi]

If someone openened a new issue report for that spammy prompt, let's continue our discussion there please.
I would open it, but I am too busy today with an rpi4 that... "misbehaves" :D
And that is the reason I have opened brave 2-3 times today, but the prompt spammed me only once.

[pitsi]

After a full day of opening and closing brave dozens of times I noticed that the issue no longer happens, at least on my end, so I won't open the report I was saying.