Truncate decimals for whole numbers in tipping amounts in tipping banner/UI #15022

Miyayes · 2021-03-30T16:40:47Z

Description

Enforce the following logic in the tipping UI in order to better display various amounts of BAT:

In the tipping banner, if the value is a whole number (e.g., 1.00 BAT, 5.00 BAT, 10.00 BAT), then truncate the decimals so that the number appears as 1 BAT, 5 BAT, 10 BAT.
Otherwise, display the decimals (e.g., 0.25 BAT, 1.75 BAT, etc.)

Per design team @jenn-rhim.

The text was updated successfully, but these errors were encountered:

Miyayes · 2021-03-31T18:41:50Z

Related: #15050

GeetaSarvadnya · 2021-04-19T08:58:00Z

Verification passed on

Brave | 1.24.65 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified the test plan from Allow fractional tipping amounts in the tip dialog brave-core#8404
Logged Wallet balance isn't shown correctly after sending one-time/recurring tips to various pubs #15384

Tipping via Rewards BAT - Verified publisher with default tipping banner

One-time tips with 1.37 BAT tipping amount

Ensured that 1.37 BAT One-time tipping amount is shown in tipping banner

Ensured Total One-Time tipping amount and individual pubs tipping amount is shown correctly in Tips panel

Ensured Total One-Time tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

One-time tips with 10.5 BAT tipping amount

Ensured that 10.5 BAT One-time tipping amount is shown in tipping banner

Ensured Total One-Time tipping amount and individual pubs tipping amount is shown correctly in Tips panel

Ensured Total One-Time tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

One-time tips with 5 BAT tipping amount

Ensured that 5 BAT One-time tipping amount is shown in tipping banner

Ensured Total One-Time tipping amount and individual pubs tipping amount is shown correctly in Tips panel

Ensured Total One-Time tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

One-time tips with_Tip set (1.25+5+10.5)

Ensured Tip set 1.25 BAT, 5 BAT and 10.5 BAT are displayed on the tipping banner

Sent One-time tips 1.25 BAT, 5 BAT, and 10.5 BAT to a verified pubs and ensured wallet balance is shown correctly

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Recurring tips with_Tip set (1.25+5+10.5)

Ensured Tip set 1.25 BAT, 5 BAT and 10.5 BAT are displayed on the tipping banner

Sent Recurring tips 1.25 BAT, 5 BAT, and 10.5 BAT to a verified pub and ensured wallet balance is shown correctly

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Recurring tips with 1.37 BAT tipping amount

Ensured that 1.37 BAT monthly tipping amount is shown in tipping banner

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Contributions panel

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Recurring tips with 0.25 BAT tipping amount

Ensured that 0.25 BAT monthly tipping amount is shown in tipping banner

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Recurring tips all combinations (0.25+1+5)

Differnt recurring tips sent to various publishers

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Tipping via Rewards BAT - Verified publisher with Custom tipping banner

One time tipping - Screenshots

Ensured that one-time tipping works as expected when we tip verified pubs with custom tipping banner

Recurring tipping - Screenshots

Ensured that recurring tips work as expected when we tip verified pubs with custom tipping banner

Tipping via Rewards BAT - Non verified publisher

Non verified pubs - Screenshots

Verified tips sent to non verified publisher goes to pending contributions table

Tipping via Uphold BAT - Verified publisher

Screenshots

Recurring tip and one-time tips sent to various publishers

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Ensured that BAT distribution among verified publisher and brave fee (5%) is shown correctly in uphold transaction list

Tipping via Uphold BAT_Tip set(1.25+5+10.5) - Verified publisher

Screenshots

Ensured Tip set 1.25 BAT, 5 BAT and 10.5 BAT are displayed on the tipping banner

Sent One-time tips 1.25 BAT, 5 BAT, and 10.5 BAT to a verified pubs

Ensured Total Monthly tipping amount and individual pubs tipping amount is shown correctly in Monthly Statement

Ensured that the total amount and the contributed amount is shown correctly in the Rewards internal page

Ensured that BAT distribution among verified publisher and brave fee (5%) is shown correctly in uphold transaction list

*****
Issues encountered

Reddit tipping button is formatted wrong when mod (Reddit tipping button is formatted wrong when mod #9556)
Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings ( Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings #12870)
Token grants claimed value is 0.0 BAT in Monthly Statement (UGP Token grants claimed value is 0.0 BAT in Monthly Statement #8961)

Verified passed with

Brave	1.24.81 Chromium: 90.0.4430.93 (Official Build) (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 10.15.7 (Build 19H1030)

Testing notes can be found under #15050 (comment) as the test plan is the same for this and that issue.

Verification passed on

Brave	1.24.81 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	Ubuntu 18.04 LTS

Verification done in #15050

srirambv · 2021-05-05T11:48:52Z

Removing Android label as Android specific issue is logged #15618

Miyayes added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 30, 2021

Miyayes changed the title ~~Truncate decimals for whole numbers in suggested tipping amounts in tipping banner/UI~~ Truncate decimals for whole numbers in tipping amounts in tipping banner/UI Mar 30, 2021

Miyayes added the feature/rewards label Mar 31, 2021

zenparsing self-assigned this Mar 31, 2021

zenparsing mentioned this issue Mar 31, 2021

Allow fractional tipping amounts in the tip dialog brave/brave-core#8404

Merged

24 tasks

zenparsing closed this as completed in brave/brave-core#8404 Apr 1, 2021

zenparsing added this to the 1.24.x - Nightly milestone Apr 2, 2021

zenparsing added QA/Yes release-notes/exclude labels Apr 5, 2021

GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 19, 2021

LaurenWags added the QA/Test-All-Platforms label Apr 19, 2021

GeetaSarvadnya mentioned this issue Apr 20, 2021

Wallet balance isn't shown correctly after sending one-time/recurring tips to various pubs #15384

Closed

GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 20, 2021

LaurenWags added the QA Pass-macOS label Apr 30, 2021

btlechowski added the QA Pass-Linux label May 1, 2021

srirambv removed the OS/Android Fixes related to Android browser functionality label May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Truncate decimals for whole numbers in tipping amounts in tipping banner/UI #15022

Truncate decimals for whole numbers in tipping amounts in tipping banner/UI #15022

Miyayes commented Mar 30, 2021 •

edited

Loading

Miyayes commented Mar 31, 2021

GeetaSarvadnya commented Apr 19, 2021 •

edited by btlechowski

Loading

srirambv commented May 5, 2021

Truncate decimals for whole numbers in tipping amounts in tipping banner/UI #15022

Truncate decimals for whole numbers in tipping amounts in tipping banner/UI #15022

Comments

Miyayes commented Mar 30, 2021 • edited Loading

Description

Miyayes commented Mar 31, 2021

GeetaSarvadnya commented Apr 19, 2021 • edited by btlechowski Loading

srirambv commented May 5, 2021

Miyayes commented Mar 30, 2021 •

edited

Loading

GeetaSarvadnya commented Apr 19, 2021 •

edited by btlechowski

Loading