Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fractional tipping amounts in the tip dialog #8404

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#15050
Resolves brave/brave-browser#15022

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenarios

One-time tips with fractional custom tipping amount

  • Given that a creator has specified a fractional tipping amount
  • When the user opens the creator's tipping dialog and selects "One Time Tip"
  • Then the tipping dialog should display the fractional tipping amount correctly (e.g. 0.25)
  • And the tip should be processed successfully

Monthly tips with fractional custom tipping amount

  • Given that a creator has specified a fractional tipping amount
  • When the user opens the creator's tipping dialog and selects "Monthly Tip"
  • Then the tipping dialog should display the fractional tipping amount correctly (e.g. 0.25)
  • And the tip should be processed successfully

One-time tip with fractional default tipping amount

  • Given that the default one time tip amount list returned from the server contains a fractional amount
  • And a creator that has not specified a custom tipping amount
  • When the user opens the creator's tipping dialog and selects "One Time Tip"
  • Then the tipping dialog should display the fractional tipping amount correctly (e.g. 0.25)
  • And the tip should be processed successfully

Monthly tip with fractional default tipping amount

  • Given that the default monthly time tip amount list returned from the server contains a fractional amount
  • And a creator that has not specified a custom tipping amount
  • When the user opens the creator's tipping dialog and selects "Monthly Tip"
  • Then the tipping dialog should display the fractional tipping amount correctly (e.g. 0.25)
  • And the tip should be processed successfully

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants