Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable re-ordering of sidebar items #15135

Closed
simonhong opened this issue Apr 6, 2021 · 1 comment · Fixed by brave/brave-core#8606 or brave/brave-core#8646
Closed

Enable re-ordering of sidebar items #15135

simonhong opened this issue Apr 6, 2021 · 1 comment · Fixed by brave/brave-core#8606 or brave/brave-core#8646
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.25.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Apr 6, 2021 •
edited
Loading

This is sub issue of #14980

Enable sidebar feature via brave://flags
Re-orders item by drag and drop.
Re-ordering in one browser window is synced with other browser windows. but active item is not synced.
@simonhong simonhong self-assigned this Apr 6, 2021
@simonhong simonhong mentioned this issue Apr 6, 2021
Closed
28 tasks
@simonhong simonhong added the feature/sidebar Relating to Brave's Sidebar feature label Apr 6, 2021
@simonhong simonhong mentioned this issue Apr 19, 2021
Closed
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 19, 2021
@simonhong simonhong mentioned this issue Apr 22, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Apr 22, 2021
@simonhong
WIP: Sidebar item reordering part 2 : UI
1588006 
fix brave/brave-browser#15135
@simonhong simonhong added QA/Yes and removed QA/No labels Apr 26, 2021
simonhong added a commit to brave/brave-core that referenced this issue Apr 26, 2021
@simonhong
Sidebar item reordering part 2 : UI
b6ff2c0 
fix brave/brave-browser#15135

Sidebar items can be re-ordered by drag and drop.
Used views::DragController instead of custom controller.
@simonhong simonhong added this to the 1.25.x - Nightly milestone Apr 26, 2021
@simonhong simonhong mentioned this issue Apr 26, 2021
Merged
24 tasks
@stephendonner
Copy link

Verified PASSED using

Brave 1.25.46 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3 (Build 20E232)

Confirmed I was able to:

  1. enable the Sidebar feature via brave://flags
  2. drag and drop all Sidebar items except for the +, which remained in place
  3. see item reordering in real time, across tabs, after the drag event finished
  4. open an item and still re-arrange other items via drag and drop, without affecting the other tab, nor the current tab, but updates to the ordering still worked
  5. add an item (GitHub) to the Sidebar and have it both appear on the other tab, as well as drag and drop-rearrange successfully

sidebar-reordering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
3 participants
@stephendonner @rebron @simonhong