Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards error logged repeatedly on private new tab page #15417

Closed
zenparsing opened this issue Apr 21, 2021 · 1 comment · Fixed by brave/brave-core#8594
Closed

Rewards error logged repeatedly on private new tab page #15417

zenparsing opened this issue Apr 21, 2021 · 1 comment · Fixed by brave/brave-core#8594

Comments

@zenparsing
Copy link

Description

In a private browser context, the new tab page will repeatedly log the following error:

"Unchecked runtime.lastError: Rewards service is not initialized", source: chrome://newtab/ (0)

Steps to Reproduce

  1. Open a new private window.
  2. Open developer tools and select the console tab.
  3. Wait 30 seconds.

Actual result:

Every 30 seconds a rewards error is logged.

Expected result:

An error should not be logged.

@stephendonner
Copy link

Verified PASSED using nightly build

Brave 1.25.46 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3 (Build 20E232)

Screen Shot 2021-04-27 at 3 43 28 PM

Confirmed the Rewards error from #15417 (comment) is no longer spamming the console's Error tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment