Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bitFlyer feature by default #15631

Closed
zenparsing opened this issue May 5, 2021 · 1 comment · Fixed by brave/brave-core#8712
Closed

Enable bitFlyer feature by default #15631

zenparsing opened this issue May 5, 2021 · 1 comment · Fixed by brave/brave-core#8712

Comments

@zenparsing
Copy link

zenparsing commented May 5, 2021

In 1.24 HF2 we would like to enable the bitFlyer feature flag by default.

@btlechowski
Copy link

btlechowski commented May 7, 2021

Verification passed on

Brave 1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Ubuntu 18.04 LTS

Verified bitFlyer feature flag is set to Enabled by default.

![image](https://user-images.githubusercontent.com/34715963/117443345-4eccb500-af38-11eb-8164-ed6dbea1aca9.png)

Verification passed on

Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified the test plan from brave/brave-core#8712

Clean profile
  • Confirmed that when region = Japan, bitFlyer feature is enabled by default
  • Confirmed click on Verify wallet navigates to bitFlyer login page
  • Confirmed BAT strings are displayed in brave://rewards page
  • Confirmed that click on Verify my wallet opens up Verify wallet modal popup
Verify my wallet button Verify wallet modal popup
image image

Confirmed BAT strings are displayed in BR panel, Rewards settings page, NTP, Tips panel, Monthly contributions panel, summary, monthly statements and rewards internal page.

BR panel Rewards settings NTP page
image image image

One-time tips

Example Example Example Example Example Example
image image image image image image

Recurring tips

Example Example Example Example Example Example
image image image image image image
Upgrade profile
  • Installed 1.23.x and balance showed as 0 BAP in UI and BAP is displayed in brave://rewards
  • Confirmed unblinded_tokens table is empty in 1.23.x
  • Upgraded profile to 1.24.x and ensured BAT is shown in brave://rewrads settings page, BR Panel, Tips panel, Monthly contribution, monthly statement, rewards internal page and NTP.
  • Confirmed that click on Verify my wallet opens up Verify wallet modal popup
  • Confirmed click on Verify wallet navigates to bitFlyer login page
1.23.x Example 1.23.x Example 1.23.x Example 1.23.x Example 1.23.x Example 1.23.x Example
image image image image image image
1.23.x DB 1.23.x UI
image image
1.24.x DB 1.24.x UI
image image

Verified passed with

Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) (x86_64)
-- | --
変更履歴 | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | macOS バージョン10.15.7(ビルド19H1030)

Verified test plan from brave/brave-core#8712

Clean profile
  • Confirmed that when region = Japan, bitFlyer feature is enabled by default
  • Confirmed that click on Verify my wallet opens up Verify wallet modal popup
  • Confirmed click on Verify wallet navigates to bitFlyer login page
  • Confirmed BAT strings are displayed in brave://rewards page
  • Spot checked panel, tipping banners, NTP widget to confirm BAT strings are displayed
Example Example Example
スクリーンショット 2021-05-07 14 31 55 スクリーンショット 2021-05-07 14 32 39 スクリーンショット 2021-05-07 14 33 19
Upgrade profile

Confirmed BAP shown in UI for 1.24.82.
Confirmed unable to verify wallet with 1.24.82.

Example Example
スクリーンショット 2021-05-07 15 00 37 スクリーンショット 2021-05-07 15 00 59
  • Confirmed that after upgrade to 1.25.83, bitFlyer feature is enabled by default
  • Confirmed that click on Verify my wallet opens up Verify wallet modal popup
  • Confirmed click on Verify wallet navigates to bitFlyer login page
  • Confirmed BAT strings are displayed in brave://rewards page
  • Spot checked panel, tipping banners, NTP widget to confirm BAT strings are displayed
Example Example
スクリーンショット 2021-05-07 15 05 13 スクリーンショット 2021-05-07 15 05 23

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment