Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bitFlyer by default (uplift to 1.25.x) #8727

Merged
merged 1 commit into from
May 7, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 6, 2021

Uplift of #8712
Resolves brave/brave-browser#15631

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 6, 2021 15:18
@brave-builds brave-builds requested review from bsclifton, zenparsing and a team and removed request for a team May 6, 2021 15:18
@brave-builds brave-builds self-assigned this May 6, 2021
@brave-builds brave-builds added this to the 1.25.x - Beta milestone May 6, 2021
@kjozwiak
Copy link
Member

kjozwiak commented May 6, 2021

test-browser failed on post-init as per https://ci.brave.com/job/pr-brave-browser-pr8712_ksmith-enable-bitflyer_1.25.x-linux/1/testReport. However, I'm going to restart as it only takes ~30min for post-init to pass.

linux / test-browser / RewardsContributionBrowserTest.AutoContributionMultiplePublishersUphold
linux / test-browser / RewardsNotificationBrowserTest.InsufficientNotificationForACNotEnoughFunds

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-pr8712_ksmith-enable-bitflyer_1.25.x-linux/1/testReport. However, these are known intermittent failures and unrelated to this specific PR.

linux / test-browser / RewardsContributionBrowserTest.AutoContributionMultiplePublishersUphold
linux / test-browser / RewardsNotificationBrowserTest.InsufficientNotificationForACNotEnoughFunds

@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2021

post-init failed due to audit-deps warnings as per https://ci.brave.com/job/pr-brave-browser-pr8712_ksmith-enable-bitflyer_1.25.x-post-init/3/execution/node/144/log/. However, these are unrelated to this specific PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 7bad500 into 1.25.x May 7, 2021
@kjozwiak kjozwiak deleted the pr8712_ksmith-enable-bitflyer_1.25.x branch May 7, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants