Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTX widget to the New Tab page #15790

Closed
rebron opened this issue May 12, 2021 · 1 comment · Fixed by brave/brave-core#8629
Closed

Add FTX widget to the New Tab page #15790

rebron opened this issue May 12, 2021 · 1 comment · Fixed by brave/brave-core#8629

Comments

@rebron
Copy link
Collaborator

rebron commented May 12, 2021

Description

Add FTX as a widget to the New Tab page to allow for viewing markets and trading crypto on the FTX platform.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on macOS

Verified using the following build

Brave 1.26.64 Chromium: 91.0.4472.114 (Official Build) (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 10.15.7 (Build 19H114)

Clean Install

  • Verified on a clean install, FTX widget is shown and is at the last position
    image

  • Verified spinner is shown when widget is being initialized
    image

  • Verified after widget initializes, defaults to .us
    image

  • Verified View future markets loads the market view and adds a back button next to widget menu
    image

  • Verified able to connect to widget successfully
    image

  • Verified summary view is hidden by default. Clicking on the show/hide button shows the balance and tokens list
    image

  • Verified convert tab lists all available tokens with balance that can be used to converted
    image

  • Verified selecting a token shows market asset details
    image

  • Verified sad smiley is shown in market details view when network is not able to fetch the value
    image

  • Verified when quote is loading the spinner icon is shown
    image

  • Verified quote is shown before confirmation of converting assets
    image

  • Verified upon successful conversion confirmation message is shown
    image

  • Verified new assets are automatically added in summary view when a successful conversion is done

  • Verified when there is no balance convert tab & summary tab shows message to add funds

image image
  • Verified when network disconnects and try to convert an asset from quote, shows zero balance message
    image

  • Verified disconnecting the widget works via widget menu

  • Verified after disconnect widget goes back to default state and defaults to .us

  • Verified click on connect tries to re-authenticate

  • Verified able to disconnect the widget by hiding the widget either via menu or via edit cards window

  • Verified when quote expires, widget goes back to convert view

  • Verified widget auto-updates every 30sec.

  • Verified when widget is authenticated and network disconnected, summary shows zero balance message, reconnecting to network after 30sec auto updates the widget and shows the balance

  • Verified widget is not shown on both clean install or upgrade for countries mentioned in https://github.com/brave/brave-core/blob/1995c8073ea0bac88db06d788f7b648bd19b6dd0/components/ftx/browser/regions.h#L15

Upgrade


Verification passed on Linux

Verified using the following build

Brave 1.26.64 Chromium: 91.0.4472.114 (Official Build) (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS Linux

Clean Install

  • Verified on a clean install, FTX widget is shown and is at the last position
    image

  • Verified spinner is shown when widget is being initialized
    image

  • Verified after widget initializes, defaults to .us
    image

  • Verified View future markets loads the market view and adds a back button next to widget menu
    image

  • Verified able to connect to widget successfully
    image

  • Verified summary view is hidden by default. Clicking on the show/hide button shows the balance and tokens list
    image

  • Verified convert tab lists all available tokens with balance that can be used to converted
    image

  • Verified selecting a token shows market asset details
    image

  • Verified sad smiley is shown in market details view when network is not able to fetch the value
    image

  • Verified when quote is loading the spinner icon is shown
    image

  • Verified quote is shown before confirmation of converting assets
    image

  • Verified upon successful conversion confirmation message is shown
    image

  • Verified new assets are automatically added in summary view when a successful conversion is done

  • Verified when there is no balance convert tab & summary tab shows message to add funds

image image
  • Verified when network disconnects and try to convert an asset from quote, shows zero balance message
    image

  • Verified disconnecting the widget works via widget menu

  • Verified after disconnect widget goes back to default state and defaults to .us

  • Verified click on connect tries to re-authenticate

  • Verified able to disconnect the widget by hiding the widget either via menu or via edit cards window

  • Verified when quote expires, widget goes back to convert view

  • Verified widget auto-updates every 30sec.

  • Verified when widget is authenticated and network disconnected, summary shows zero balance message, reconnecting to network after 30sec auto updates the widget and shows the balance

  • Verified widget is not shown on both clean install or upgrade for countries mentioned in https://github.com/brave/brave-core/blob/1995c8073ea0bac88db06d788f7b648bd19b6dd0/components/ftx/browser/regions.h#L15

Upgrade


Verification passed on Windows 10

Verified using the following build

Brave 1.26.64 Chromium: 91.0.4472.114 (Official Build) (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS Windows 10 OS Version 2009 (Build 19042.1052)

Clean Install

  • Verified on a clean install, FTX widget is shown and is at the last position
    image

  • Verified spinner is shown when widget is being initialized
    image

  • Verified after widget initializes, defaults to .us
    image

  • Verified View future markets loads the market view and adds a back button next to widget menu
    image

  • Verified able to connect to widget successfully
    image

  • Verified summary view is hidden by default. Clicking on the show/hide button shows the balance and tokens list
    image

  • Verified convert tab lists all available tokens with balance that can be used to converted
    image

  • Verified selecting a token shows market asset details
    image

  • Verified sad smiley is shown in market details view when network is not able to fetch the value
    image

  • Verified when quote is loading the spinner icon is shown
    image

  • Verified quote is shown before confirmation of converting assets
    image

  • Verified upon successful conversion confirmation message is shown
    image

  • Verified new assets are automatically added in summary view when a successful conversion is done

  • Verified when there is no balance convert tab and summary tab shows message to add funds

image image
  • Verified when network disconnects and try to convert an asset from quote, shows zero balance message
    image

  • Verified disconnecting the widget works via widget menu

  • Verified after disconnect widget goes back to default state and defaults to .us

  • Verified click on connect tries to re-authenticate

  • Verified able to disconnect the widget by hiding the widget either via menu or via edit cards window

  • Verified when quote expires, widget goes back to convert view

  • Verified widget auto-updates every 30sec.

  • Verified when widget is authenticated and network disconnected, summary shows zero balance message, reconnecting to network after 30sec auto updates the widget and shows the balance

  • Verified widget is not shown on both clean install or upgrade for countries mentioned in https://github.com/brave/brave-core/blob/1995c8073ea0bac88db06d788f7b648bd19b6dd0/components/ftx/browser/regions.h#L15

Upgrade

@rebron rebron changed the title Add FTX widget Add FTX widget to the New Tab page Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants