Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding uphold user ID to brave://rewards-internals #16937

Closed
bsclifton opened this issue Jul 13, 2021 · 4 comments · Fixed by brave/brave-core#9529
Closed

Consider adding uphold user ID to brave://rewards-internals #16937

bsclifton opened this issue Jul 13, 2021 · 4 comments · Fixed by brave/brave-core#9529

Comments

@bsclifton
Copy link
Member

Description

I ran into the linking issue (see #14927) recently and it was difficult to get the problem resolved. I had to provide folks with the Uphold ID which we don't seem to display in the UI.

In my example, I had to get the ID via uphold.com using network tab (in developer tools). You can see it in the https://api.uphold.com/v0/me/transactions request - in the response JSON you need to look for your username; there will be a guid in the id field at the same level as the username field.

Having this ID would make any action we'd like to take with #14927 a lot easier. For example, if we wanted to have a support workflow for that situation

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 14, 2021

@szilardszaloki, do you happen to know an easy way the browser might have access to this field (e.g., is it ever returned during one of the user's requests to Uphold)? If so, then we could have it displayed in brave://rewards-internals.

@szilardszaloki
Copy link
Contributor

@Miyayes Yep, currently we don't parse it, but it's in the Uphold user object (Get User request).

@stephendonner
Copy link

Verified PASSED using the testplan from brave/brave-core#9529 with
brave/brave-core#9529

Brave 1.29.42 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 12.0 (Build 21A5294g)

Steps:

  1. new profile
  2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. enabled Rewards
  4. clicked on Verify Wallet from brave://rewards and logged in with my KYC'd Uphold account
  5. confirmed Custodian and Custodian member ID were shown in brave://rewards-internals
  6. disconnected Uphold account from Rewards
  7. confirmed Custodian and Custodian member ID are not shown in brave://rewards-internals
  8. confirmed for both bitFlyer and Gemini that only Custodian is shown.
Uphold bitFlyer Gemini disconnected
Screen Shot 2021-08-02 at 1 34 54 PM Screen Shot 2021-08-02 at 11 19 44 AM Screen Shot 2021-08-02 at 11 31 11 Screen Shot 2021-08-02 at 11 20 28 AM

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.29.70 x64 Beta build

  • Verified Uphold User ID is shown on brave://rewards-internals when a KYC'd wallet is connected
Disconnected Connected
image image

Verification passed on Samsung Tab A with Android 11 running 1.29.70 x64 Beta build

  • Verified Uphold User ID is shown on brave://rewards-internals when a KYC'd wallet is connected
Disconnected Connected
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment