Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Custodian and Custodian member ID to rewards-internals. #9529

Merged

Conversation

szilardszaloki
Copy link
Collaborator

@szilardszaloki szilardszaloki commented Jul 22, 2021

Resolves brave/brave-browser#16937.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

For Uphold:

  1. Enable Rewards
  2. Select Verify Wallet and log in with KYC'd Uphold account
  3. Confirm Custodian and Custodian member ID are shown in brave://rewards-internals
  4. Disconnect Uphold account from Rewards
  5. Confirm Custodian and Custodian member ID are not shown in brave://rewards-internals

For bitFlyer and Gemini, confirm that only Custodian is shown.

We only display Custodian or Custodian member ID if wallet status is not NOT_CONNECTED.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szilardszaloki szilardszaloki force-pushed the sszaloki-16937-adding-member-id-to-rewards-internals branch 2 times, most recently from 15d0447 to 4035774 Compare July 22, 2021 18:56
@szilardszaloki szilardszaloki force-pushed the sszaloki-16937-adding-member-id-to-rewards-internals branch from 4035774 to 76a862e Compare July 23, 2021 18:56
@szilardszaloki szilardszaloki modified the milestone: 1.29.x - Nightly Jul 23, 2021
@szilardszaloki szilardszaloki merged commit 3c72b39 into master Jul 23, 2021
@szilardszaloki szilardszaloki deleted the sszaloki-16937-adding-member-id-to-rewards-internals branch July 23, 2021 21:32
@szilardszaloki szilardszaloki added this to the 1.29.x - Nightly milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding uphold user ID to brave://rewards-internals
2 participants