Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor windows should be closed when Tor is disabled #16959

Closed
darkdh opened this issue Jul 14, 2021 · 1 comment · Fixed by brave/brave-core#9440
Closed

Tor windows should be closed when Tor is disabled #16959

darkdh opened this issue Jul 14, 2021 · 1 comment · Fixed by brave/brave-core#9440

Comments

@darkdh
Copy link
Member

darkdh commented Jul 14, 2021

When users go to brave://settings/extensions and disable Tor through Private window with Tor switch, existing Tor windows should be automatically closed because those windows are no longer abled to connect to Tor network.

@stephendonner
Copy link

stephendonner commented Jul 19, 2021

Verified PASSED using

Brave 1.29.8 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. opened 2 New private window with Tor windows
  4. opened 2 New Private window windows
  5. clicked on Create a New Profile
  6. opened 2 New Private window windows and 2 New private window with Tor windows
  7. loaded brave://settings/?search=onion
  8. toggled Private window with Tor to Off
  9. confirmed all 4 New private window with Tor windows were automatically closed
  10. confirmed all 4 New Private window windows remained

toggle-tor-off


Verification passed on

Brave 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Ubuntu 18.04 LTS

Verified the above tes plan

Before disabling tor:
image

After disabling tor, verified all tor windows were closed:
image


Verification passed on


Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Confirmed all the opened Tor windows are closed when the toggle Private window with Tor is disabled under brave://settings/extensions
all Tor windows close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment