Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show "Your wallet is verified!" message when reconnecting after natural disconnect #17278

Closed
LaurenWags opened this issue Jul 30, 2021 · 6 comments · Fixed by brave/brave-core#9738
Assignees
Labels

Comments

@LaurenWags
Copy link
Member

Description

Per discussion in https://bravesoftware.slack.com/archives/CB0KCRCQN/p1627659102017500, we should not show the "Your wallet is verified!" message/notification when a user is reconnecting after natural disconnect.

Steps to Reproduce

  1. Clean profile 1.29.x, staging env
  2. Enable Rewards
  3. Link KYC'd, verified Uphold account
  4. Simulate "natural" disconnect by revoking Brave-Browser app authorization on Uphold site
  5. Confirm UI shows "Disconnected"/no balance
  6. Click on "Disconnected" and reauthorize Uphold
  7. You are successful in re-auth and you get this notification

Also reproduces in this scenario:

  1. Using current release version, 1.27.109, clean profile, staging env, enable Rewards, link KYC'd Uphold wallet
  2. Simulate "natural" disconnect by revoking Brave-Browser app authorization on Uphold site
  3. Close browser
  4. "Upgrade" (rename profile to Brave-Browser-Nightly) to 1.29.x
  5. Confirm your verified, KYC'd wallet is still in Disconnected status after upgrade (appropriate UI, no Uphold balance shown)
  6. Click on "Disconnected" and re-auth with Uphold

Actual result:

Your wallet is verified notification:
Screen Shot 2021-07-30 at 11 26 04 AM

Expected result:

No notification in this case

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.29.40 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 11.5.1 (Build 20G80)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @szilardszaloki

@GeetaSarvadnya
Copy link

Reproduced the issue in Windows 10 x64 - 1.29.58

@szilardszaloki
Copy link
Contributor

Hey @GeetaSarvadnya!
FYI: brave/brave-core#9738 is not getting uplifted to 1.29.x.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 1, 2021

@szilardszaloki Looks like the issue is not yet fixed, verified the issue in the nightly build 1.31.12 and beta build 1.30.59

Brave | 1.30.59 Chromium: 93.0.4577.58 (Official Build) beta (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

And

Brave | 1.31.12 Chromium: 93.0.4577.58 (Official Build) nightly (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Logged a follow up issue #17807

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 1, 2021

Verified passed on

Brave | 1.30.59 Chromium: 93.0.4577.58 (Official Build) beta (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Verified the STR from the description, the issue is fixed and working fine in both scenarios mentioned above

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 1, 2021
@szilardszaloki
Copy link
Contributor

@GeetaSarvadnya That's odd. Just took a look with 1.31.10 and it was working fine. Let me rebase and try that again!

@szilardszaloki
Copy link
Contributor

@GeetaSarvadnya Just tried with 1.31.14 Chromium: 93.0.4577.63 and actually it's working fine. I'll reach out to you via Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants