Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uphold doesn't always get the "Disconnected" UI/Disconnected (Verified) state correctly #17329

Closed
LaurenWags opened this issue Aug 3, 2021 · 2 comments · Fixed by brave/brave-core#9654

Comments

@LaurenWags
Copy link
Member

Description

When you naturally disconnect from Uphold you should see the "Disconnected" UI (different from explicit disconnect). However, depending on whether you access rewards panel or brave://rewards page first is determining whether you get the proper UI/state.

Does not reproduce with Gemini in 1.29.x.

Does not reproduce with 1.27.x or 1.28.x with Uphold.

Steps to Reproduce

  1. Clean profile, non-Japan region, staging environment.
  2. Enable Rewards
  3. Link a KYC'd Uphold wallet
  4. Confirm wallet is linked (balance shows in browser, etc)
  5. Navigate to Uphold site (make sure brave://rewards page is closed if open in any tabs)
  6. Revoke Brave-Browser access to simulate natural disconnect
  7. Open panel
    --> No "Disconnected" UI, see "Verify wallet" instead
    --> Open brave://rewards page, no "Disconnected" UI, see "Verify wallet" instead
    --> Open brave://rewards-internals, see Wallet status as Not connected

If at step 7 you open brave://rewards page instead of the panel, you correctly get "Disconnected" UI on rewards page, panel, and internals page (wallet status is "Disconnected (Verified)").

Actual result:

Example Example Example
Screen Shot 2021-08-03 at 2 58 03 PM Screen Shot 2021-08-03 at 2 58 10 PM Screen Shot 2021-08-03 at 2 58 19 PM

Expected result:

Example Example Example
Screen Shot 2021-08-03 at 2 59 12 PM Screen Shot 2021-08-03 at 2 59 21 PM Screen Shot 2021-08-03 at 2 59 29 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.29.46 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
-- | --
Revision | 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS | macOS Version 10.15.7 (Build 19H1217)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, does not reproduce on 1.27.109
  • Can you reproduce this issue with the beta channel? no, does not reproduce on 1.28.100
  • Can you reproduce this issue with the nightly channel? yes 1.29.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @szilardszaloki

@LaurenWags
Copy link
Member Author

Changing milestone to 1.29.x since brave/brave-core#9701 was merged cc @kjozwiak

@LaurenWags LaurenWags added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 12, 2021
@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 18, 2021

Verified passed with

Brave | 1.29.63 Chromium: 92.0.4515.131 (Official Build) beta (x86_64)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | macOS Version 10.15.7 (Build 19H1323)

Verified STR from description.
Confirmed I correctly get the "Disconnected" UI/state when opening the panel or brave://rewards after simulating natural disconnect from Uphold.

Example Example Example
1 2 3

Verification passed on

Brave | 1.29.64 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
-- | --
Revision | 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Verified STR from description.
Confirmed I correctly get the "Disconnected" UI/state when opening the panel or brave://rewards after simulating natural disconnect from Uphold.
After simulating natural disconnect from Uphold encountered the issue while opening the panel #17278

Example Example Example
image image image

Verified passed with

Brave	1.29.71 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision	0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS	Linux

Verified STR from description.
Confirmed I correctly get the "Disconnected" UI/state when opening the panel or brave://rewards after simulating natural disconnect from Uphold.

Example Example Example
1 2 3

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 18, 2021
@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment