Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button text not clearly visible on dark theme #17587

Closed
srirambv opened this issue Aug 20, 2021 · 2 comments · Fixed by brave/brave-core#9830
Closed

Button text not clearly visible on dark theme #17587

srirambv opened this issue Aug 20, 2021 · 2 comments · Fixed by brave/brave-core#9830

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 20, 2021

Description

Button text not clearly visible on dark theme

Steps to reproduce

  1. Set browser/device to dark theme
  2. Open clear data page
  3. Text on Clear data button isn't clearly visible

Actual result

CR 93 CR 92
image image

Light theme for comparision

CR 93 CR 92
image image

Expected result

The button text should be white on both light and dark theme. We should not be using inverted text colors for dark theme.

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11

Brave version

1.30.34 x64 Nightly build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Other screens where the buttons have issues

Add Card Add Address
image image
@srirambv srirambv added bug QA/Yes regression OS/Android Fixes related to Android browser functionality labels Aug 20, 2021
@srirambv
Copy link
Contributor Author

Also the colour scheme for the more info button is different from current release build

@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 11 running 1.29.74 64 build

  • Verified button text is clearly visible on both light and dark mode
image image image
image image image

Verification passed on Oppo Reno 5 with Android 11 running 1.29.74 64 build

  • Verified button text is clearly visible on both light and dark mode
image image image
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants