Upgrade from Chromium 92 to Chromium 93 #9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariospr
force-pushed
the
cr93
branch
9 times, most recently
from
a62667f
to
69f011c
Compare
mariospr
force-pushed
the
cr93
branch
11 times, most recently
from
aaf5f37
to
03f0a04
Compare
24 tasks
mariospr
force-pushed
the
cr93
branch
5 times, most recently
from
32c63d2
to
f0ac9fb
Compare
…roperty binding is setup Previously we were creating the elements directly on the document. That led to the constructor being called immediately. When we create as a template element first then we avoid that issue.
…the actual element. We need to: - Make sure chromium's component does not get registered, so we add a dep to a JS module which makes sure the element name is on an ignore list - Define our own element which subclasses chromium's one and accesses and modifies the original static property
…efore brave's overrides have run
Browser tests error out on Windows CI with content/public/test/test_utils.cc(137): error: Failed RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:800. Running with --disable-gpu avoids the error, but causes various WebGL tests to fail. Running with --no-sandbox avoids the error. Running with --disable-gpu-sandbox also avoids the error - picked this one is the least bad from the 2 above. It is not clear ATM what's causing the error. Only adds the flag on Windows in Release config.
Followup to a prior commit that follows upstream and renames ProfileSyncService to SyncServiceImpl in various class names.
…ser#10643 This browser tests got moved into //brave/browser/brave_shields but got removed from its original location, so let's do it now.
This migrates away from WebContentsReceiverSet and avoids having to friend WebContentsFrameReceiverSetPassKey with BraveDRMTabHelper.
…rSet This migrates away from WebContentsReceiverSet and avoids having to friend WebContentsFrameReceiverSetPassKey with BraveShieldsWebContentsObserver.
….cc.patch I initially thought we'd be better off for now with a one-line patch to avoid complicating things too much on the verge of the merge, but turns out that we already subclass ChromeContentBrowserClient, and so we can avoid patching by overriding BindAssociatedReceiverFromFrame() from there to extend it with the binders for our own mojo interfaces.
The patch was introduced here #2514 but upstream added the same functionality in Cr81 here chromium/chromium@432be5c
24 tasks
mkarolin
added a commit
that referenced
this pull request
Aug 24, 2021
Upgrade from Chromium 92 to Chromium 93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#16306
Related PR: brave/brave-browser#16679
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: