Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wallet state notifications for Android #17780

Closed
srirambv opened this issue Aug 31, 2021 · 2 comments
Closed

Implement wallet state notifications for Android #17780

srirambv opened this issue Aug 31, 2021 · 2 comments
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

As part of #15390, new notifications are implemented for various wallet connection state (Pending/Blocked/Restricted/BAT not available/Linking Limit). These notifications don't show up on Android and needs to be implemented to have parity between desktop and Android

Steps to reproduce

Follow test plan from brave/brave-core#9212

Actual result

No notifications shown on Android

Expected result

Show notifications on Android similar to desktop

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):Phone
  • Android version: 11

Brave version

1.29.x onward

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Miyayes @deeppandya @szilardszaloki

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 29, 2021

Is this automatically resolved via #20175?

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 26, 2022

@srirambv I think all of these error modals are gotten for free, since we do verifying/linking flow via brave://rewards settings page on Android, and all the error modals are now inherited for free from desktop. (You can see in various Rewards test cases of v1.35.) cc: @LaurenWags

@Miyayes Miyayes closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants