Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Uphold error modals need to be implemented #20175

Closed
LaurenWags opened this issue Dec 20, 2021 · 1 comment · Fixed by brave/brave-core#11661
Closed

[Android] Uphold error modals need to be implemented #20175

LaurenWags opened this issue Dec 20, 2021 · 1 comment · Fixed by brave/brave-core#11661
Assignees
Labels
feature/rewards/Uphold feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 20, 2021

Description

When using Uphold for rewards wallet provider, the following 3 error modals (at a minimum) should be implemented:

  • KYC required (user is not KYC’ed and is told they couldnt complete verification because they need to finish KYC first)
  • Device limit reached
  • Mismatched provider accounts

Steps to reproduce

Varies depending on error modal

Actual result

Ex. for device limit reached, there is no error shown in the UI at all. Nothing on panel, on chrome://rewards, or generic Android error.

Expected result

Error modal should be shown for expected case

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.35.47

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @Miyayes

ref: https://bravesoftware.slack.com/archives/C02Q4NSQSH1/p1640019081025600

@LaurenWags
Copy link
Member Author

LaurenWags commented Jan 20, 2022

Verified with 1.35.89 Chromium: 97.0.4692.71 (Official Build) beta on Google Pixel 3 XL running Android 12.

Mismatched provider accounts - PASSED

Confirmed when attempting to link a second/different KYC'd Uphold account after previously successfully linking a KYC'd account, a modal is displayed on the settings page.
Confirmed link on the modal directs to https://support.brave.com/hc/en-us/articles/360034841711-What-is-a-verified-wallet-
Confirmed the close button closes the modal.

Screenshot_20220120-163402

KYC Required - PASSED

Confirmed when attempting to link a non KYC'd account, a modal is displayed on the settings page.
Confirmed the close button closes the modal.

Screenshot_20220120-155751

Verified with 1.35.89 Chromium: 97.0.4692.71 (Official Build) beta on Google Pixel 3 XL running Android 12.

Device Limit Reached - PASSED

When server side linking limit is set to 4, confirmed unable to link KYC'd Uphold account which has already been linked 4 times and a modal is displayed on the settings page.
Confirmed link on the modal directs to https://support.brave.com/hc/en-us/articles/360056508071.
Confirmed the close button closes the modal.

Uphold


Verification passed on Samsung Tab A with Android 10 running 1.35.93

Mismatched provider accounts - PASSED
  • Verified when a KYC'd account is linked, trying to relink a second KYC'd account throws error
  • Verified clicking on the error modal loads https://support.brave.com/hc/en-us/articles/360034841711-What-is-a-verified-wallet-
  • Verified clicking on the close button closes the modal
    image
KYC Required - PASSED
  • Verified connecting a non-KYC'd account shows the following error modal
  • Verified clicking on the close button closes the modal
    image
Device Limit Reached - PASSED
  • Verified with server side linking limit set to 4, trying to connect a KYC'd account that is already linked 4 times shows the following modal
  • Verified clicking on the link loads https://support.brave.com/hc/en-us/articles/360056508071
  • Verified clicking on the close button closes the modal
    image

@LaurenWags LaurenWags added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards/Uphold feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants