Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking 'X' to exclude publisher in auto-contribute results in state counting 2 excluded sites #1873

Closed
jasonrsadler opened this issue Oct 28, 2018 · 1 comment · Fixed by brave/brave-core#797

Comments

@jasonrsadler
Copy link

Description

When clicking the exclude button next to a publisher in the auto-contribute list too quickly, it double counts the number of excluded publishers

Steps to Reproduce

  1. Open Brave and enable rewards
  2. Visit enough sites to allow for modal table to open
  3. Double click exclude

Actual result:

The number of excluded sites listed is counted twice and the site is excluded and then reincluded

Expected result:

The site should exclude properly and the number of excluded sites should reflect correct number of excluded sites. Also, appears to be a 'toggle' functionality to the exclude button whereas it should simply pass an explicit exclude value

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 0.58.1 Chromium: 70.0.3538.77 (Developer Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Unknown (Release type builds currently process exclusion faster then a double click can occur)

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@btlechowski
Copy link

btlechowski commented Dec 12, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Used STR from brave/brave-core#797

Verification passed on

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Verified passed with

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants